| Message ID | 20240517054745.4111922-2-vineeth.karumanchi@amd.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | net: xilinx_gmii2rgmii: Add clock support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/05/2024 07:47, Vineeth Karumanchi wrote: > Add input clock support to gmii_to_rgmii IP. > Add "clocks" bindings for the input clock. Both sentences look like saying the same... confused. > > Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> > --- > Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > index 0f781dac6717..672bff6dae28 100644 > --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > @@ -31,6 +31,9 @@ properties: > phy-handle: > $ref: ethernet-controller.yaml#/properties/phy-handle > > + clocks: > + description: 200/375 MHz free-running clock is used as input clock. Missing constraints. Probably you wanted items above description. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml index 0f781dac6717..672bff6dae28 100644 --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml @@ -31,6 +31,9 @@ properties: phy-handle: $ref: ethernet-controller.yaml#/properties/phy-handle + clocks: + description: 200/375 MHz free-running clock is used as input clock. + required: - compatible - reg @@ -51,5 +54,6 @@ examples: compatible = "xlnx,gmii-to-rgmii-1.0"; reg = <8>; phy-handle = <&phy>; + clocks = <&dummy>; }; };
Add input clock support to gmii_to_rgmii IP. Add "clocks" bindings for the input clock. Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> --- Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 4 ++++ 1 file changed, 4 insertions(+)