diff mbox series

[3/4] dt-bindings: arm: rockchip: Add Radxa ROCK 3B

Message ID 20240505134120.2828885-4-jonas@kwiboo.se
State Not Applicable
Headers show
Series arm64: dts: rockchip: Add Radxa ROCK 3B | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Jonas Karlman May 5, 2024, 1:41 p.m. UTC
Add devicetree binding documentation for the Radxa ROCK 3B board.

The Radxa ROCK 3B is a single-board computer based on the Pico-ITX form
factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community
version based on the RK3568 SoC and an industrial version based on the
RK3568J SoC.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski May 6, 2024, 10:48 a.m. UTC | #1
On 05/05/2024 15:41, Jonas Karlman wrote:
> Add devicetree binding documentation for the Radxa ROCK 3B board.
> 
> The Radxa ROCK 3B is a single-board computer based on the Pico-ITX form
> factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community
> version based on the RK3568 SoC and an industrial version based on the
> RK3568J SoC.
> 
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 51cdaabaf0d9..41f2ab79e612 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -799,6 +799,11 @@ properties:
>            - const: radxa,rock3a
>            - const: rockchip,rk3568
>  
> +      - description: Radxa ROCK 3B

Does not look like it matches recent fixups for names.

Best regards,
Krzysztof
Dragan Simic May 6, 2024, 11:46 a.m. UTC | #2
Hello Krzysztof,

On 2024-05-06 12:48, Krzysztof Kozlowski wrote:
> On 05/05/2024 15:41, Jonas Karlman wrote:
>> Add devicetree binding documentation for the Radxa ROCK 3B board.
>> 
>> The Radxa ROCK 3B is a single-board computer based on the Pico-ITX 
>> form
>> factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community
>> version based on the RK3568 SoC and an industrial version based on the
>> RK3568J SoC.
>> 
>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml 
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 51cdaabaf0d9..41f2ab79e612 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -799,6 +799,11 @@ properties:
>>            - const: radxa,rock3a
>>            - const: rockchip,rk3568
>> 
>> +      - description: Radxa ROCK 3B
> 
> Does not look like it matches recent fixups for names.

Actually, I can confirm that "Radxa ROCK 3B" conforms to the recently
employed naming scheme for Radxa boards.
Krzysztof Kozlowski May 6, 2024, 8:09 p.m. UTC | #3
On 06/05/2024 13:46, Dragan Simic wrote:
> Hello Krzysztof,
> 
> On 2024-05-06 12:48, Krzysztof Kozlowski wrote:
>> On 05/05/2024 15:41, Jonas Karlman wrote:
>>> Add devicetree binding documentation for the Radxa ROCK 3B board.
>>>
>>> The Radxa ROCK 3B is a single-board computer based on the Pico-ITX 
>>> form
>>> factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community
>>> version based on the RK3568 SoC and an industrial version based on the
>>> RK3568J SoC.
>>>
>>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>>> ---
>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml 
>>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> index 51cdaabaf0d9..41f2ab79e612 100644
>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> @@ -799,6 +799,11 @@ properties:
>>>            - const: radxa,rock3a
>>>            - const: rockchip,rk3568
>>>
>>> +      - description: Radxa ROCK 3B
>>
>> Does not look like it matches recent fixups for names.
> 
> Actually, I can confirm that "Radxa ROCK 3B" conforms to the recently
> employed naming scheme for Radxa boards.

Hm, I could have looked at older code.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 51cdaabaf0d9..41f2ab79e612 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -799,6 +799,11 @@  properties:
           - const: radxa,rock3a
           - const: rockchip,rk3568
 
+      - description: Radxa ROCK 3B
+        items:
+          - const: radxa,rock-3b
+          - const: rockchip,rk3568
+
       - description: Radxa ROCK 3C
         items:
           - const: radxa,rock-3c