| Message ID | 20240502182804.145926-7-christoph.fritz@hexdev.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | LIN Bus support for Linux | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, May 02, 2024 at 08:27:59PM +0200, Christoph Fritz wrote: > Add dt-bindings for serial LIN bus adapters. These adapters are > basically just LIN transceivers that are hard-wired to serial devices. > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > --- > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > new file mode 100644 > index 0000000000000..c178eb9be1391 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Serial LIN Adapter > + > +description: > + LIN transceiver, mostly hard-wired to a serial device, used for communication > + on a LIN bus. > + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. > + > +maintainers: > + - Christoph Fritz <christoph.fritz@hexdev.de> > + > +properties: > + compatible: > + const: hexdev,lin-serdev Maybe I've just missed something on earlier versions that I didn't read, but the name of the device on the website you link is "hexLIN", so why is "lin-serdev" used here instead? > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + serial { > + linbus { > + compatible = "hexdev,lin-serdev"; > + }; > + }; > -- > 2.39.2 >
Hello Conor, thanks for having an eye on this, please see my answer below. On Fri, 2024-05-03 at 18:12 +0100, Conor Dooley wrote: > On Thu, May 02, 2024 at 08:27:59PM +0200, Christoph Fritz wrote: > > Add dt-bindings for serial LIN bus adapters. These adapters are > > basically just LIN transceivers that are hard-wired to serial devices. > > > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > > --- > > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > new file mode 100644 > > index 0000000000000..c178eb9be1391 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > @@ -0,0 +1,32 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Serial LIN Adapter > > + > > +description: > > + LIN transceiver, mostly hard-wired to a serial device, used for communication > > + on a LIN bus. > > + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. > > + > > +maintainers: > > + - Christoph Fritz <christoph.fritz@hexdev.de> > > + > > +properties: > > + compatible: > > + const: hexdev,lin-serdev > > Maybe I've just missed something on earlier versions that I didn't > read, but the name of the device on the website you link is "hexLIN", > so why is "lin-serdev" used here instead? The USB one is called hexLIN and has it's own HID driver. This serial LIN adapter doesn't really have a product name. Currently on our website it's generically called 'UART LIN Adapter'. This LIN adapter is basically just a LIN transceiver and very generic, so that one could solder it to any single-board computer with an uart. I think 'lin-serdev' for LIN and serial device fits great, also serdev is the name of the used kernel infrastructure (besides the LIN glue driver). If you still don't like it, I'm open to other names. What about "hexlin-uart" or "linser"? Thanks -- Christoph >
On Fri, May 03, 2024 at 08:29:15PM +0200, Christoph Fritz wrote: > Hello Conor, > > thanks for having an eye on this, please see my answer below. > > On Fri, 2024-05-03 at 18:12 +0100, Conor Dooley wrote: > > On Thu, May 02, 2024 at 08:27:59PM +0200, Christoph Fritz wrote: > > > Add dt-bindings for serial LIN bus adapters. These adapters are > > > basically just LIN transceivers that are hard-wired to serial devices. > > > > > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > > > --- > > > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > > > 1 file changed, 32 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > new file mode 100644 > > > index 0000000000000..c178eb9be1391 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > @@ -0,0 +1,32 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Serial LIN Adapter > > > + > > > +description: > > > + LIN transceiver, mostly hard-wired to a serial device, used for communication > > > + on a LIN bus. > > > + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. > > > + > > > +maintainers: > > > + - Christoph Fritz <christoph.fritz@hexdev.de> > > > + > > > +properties: > > > + compatible: > > > + const: hexdev,lin-serdev > > > > Maybe I've just missed something on earlier versions that I didn't > > read, but the name of the device on the website you link is "hexLIN", > > so why is "lin-serdev" used here instead? > > The USB one is called hexLIN and has it's own HID driver. > > This serial LIN adapter doesn't really have a product name. Currently > on our website it's generically called 'UART LIN Adapter'. > > This LIN adapter is basically just a LIN transceiver and very generic, > so that one could solder it to any single-board computer with an uart. > > I think 'lin-serdev' for LIN and serial device fits great, also serdev > is the name of the used kernel infrastructure (besides the LIN glue > driver). > > If you still don't like it, I'm open to other names. What about > "hexlin-uart" or "linser"? I dunno, I don't really care about it being called "hexlin,lin-serdev", all that much, I just found it confusing that the link in the description sent me to the ""Hello World" in LIN" section of your site. If it had dropped me off at the "UART LIN adapter" section things woud've been less confusing. That said, calling the compatible after a linux-ism is a bit odd to me when the device seems to be called a "UART LIN adapter" on the page, not a "serdev". Cheers, Conor.
On 06/05/2024 18:16, Conor Dooley wrote: >>>> +maintainers: >>>> + - Christoph Fritz <christoph.fritz@hexdev.de> >>>> + >>>> +properties: >>>> + compatible: >>>> + const: hexdev,lin-serdev >>> >>> Maybe I've just missed something on earlier versions that I didn't >>> read, but the name of the device on the website you link is "hexLIN", >>> so why is "lin-serdev" used here instead? >> >> The USB one is called hexLIN and has it's own HID driver. >> >> This serial LIN adapter doesn't really have a product name. Currently >> on our website it's generically called 'UART LIN Adapter'. >> >> This LIN adapter is basically just a LIN transceiver and very generic, >> so that one could solder it to any single-board computer with an uart. >> >> I think 'lin-serdev' for LIN and serial device fits great, also serdev >> is the name of the used kernel infrastructure (besides the LIN glue >> driver). >> >> If you still don't like it, I'm open to other names. What about >> "hexlin-uart" or "linser"? > > I dunno, I don't really care about it being called "hexlin,lin-serdev", > all that much, I just found it confusing that the link in the description > sent me to the ""Hello World" in LIN" section of your site. If it had > dropped me off at the "UART LIN adapter" section things woud've been less > confusing. > > That said, calling the compatible after a linux-ism is a bit odd to me > when the device seems to be called a "UART LIN adapter" on the page, not > a "serdev". > If there is no real, fixed model name, I would also propose to use whatever is on the website currently and avoid Linuxism. Best regards, Krzysztof
On Mon, 2024-05-06 at 20:50 +0200, Krzysztof Kozlowski wrote: > On 06/05/2024 18:16, Conor Dooley wrote: > > > > > +maintainers: > > > > > + - Christoph Fritz <christoph.fritz@hexdev.de> > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + const: hexdev,lin-serdev > > > > > > > > Maybe I've just missed something on earlier versions that I didn't > > > > read, but the name of the device on the website you link is "hexLIN", > > > > so why is "lin-serdev" used here instead? > > > > > > The USB one is called hexLIN and has it's own HID driver. > > > > > > This serial LIN adapter doesn't really have a product name. Currently > > > on our website it's generically called 'UART LIN Adapter'. > > > > > > This LIN adapter is basically just a LIN transceiver and very generic, > > > so that one could solder it to any single-board computer with an uart. > > > > > > I think 'lin-serdev' for LIN and serial device fits great, also serdev > > > is the name of the used kernel infrastructure (besides the LIN glue > > > driver). > > > > > > If you still don't like it, I'm open to other names. What about > > > "hexlin-uart" or "linser"? > > > > I dunno, I don't really care about it being called "hexlin,lin-serdev", > > all that much, I just found it confusing that the link in the description > > sent me to the ""Hello World" in LIN" section of your site. If it had > > dropped me off at the "UART LIN adapter" section things woud've been less > > confusing. Hi Conor and Krzysztof, I guess this is a chromium oddity, because browsing to https://hexdev.de/hexlin#hexLINSER brings the user to another headline ("hexLIN" not "hexLINSER") as long as headline "hexLINSER" can be also displayed. When using firefox, the top headline is hexLINSER as expected (at least I do). > > > > That said, calling the compatible after a linux-ism is a bit odd to me > > when the device seems to be called a "UART LIN adapter" on the page, not > > a "serdev". > > > > If there is no real, fixed model name, I would also propose to use > whatever is on the website currently and avoid Linuxism. OK, I changed it to hexLINSER on the website and in the upcoming v4 revision of this patchset. LINSER for LIN and serial, or like in "Linsen & Spätzle" :) Thanks -- Christoph
On Wed, May 08, 2024 at 01:34:34PM +0200, Christoph Fritz wrote: > On Mon, 2024-05-06 at 20:50 +0200, Krzysztof Kozlowski wrote: > > On 06/05/2024 18:16, Conor Dooley wrote: > > > > > > +maintainers: > > > > > > + - Christoph Fritz <christoph.fritz@hexdev.de> > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + const: hexdev,lin-serdev > > > > > > > > > > Maybe I've just missed something on earlier versions that I didn't > > > > > read, but the name of the device on the website you link is "hexLIN", > > > > > so why is "lin-serdev" used here instead? > > > > > > > > The USB one is called hexLIN and has it's own HID driver. > > > > > > > > This serial LIN adapter doesn't really have a product name. Currently > > > > on our website it's generically called 'UART LIN Adapter'. > > > > > > > > This LIN adapter is basically just a LIN transceiver and very generic, > > > > so that one could solder it to any single-board computer with an uart. > > > > > > > > I think 'lin-serdev' for LIN and serial device fits great, also serdev > > > > is the name of the used kernel infrastructure (besides the LIN glue > > > > driver). > > > > > > > > If you still don't like it, I'm open to other names. What about > > > > "hexlin-uart" or "linser"? > > > > > > I dunno, I don't really care about it being called "hexlin,lin-serdev", > > > all that much, I just found it confusing that the link in the description > > > sent me to the ""Hello World" in LIN" section of your site. If it had > > > dropped me off at the "UART LIN adapter" section things woud've been less > > > confusing. > > Hi Conor and Krzysztof, > > I guess this is a chromium oddity, because browsing to > > https://hexdev.de/hexlin#hexLINSER > > brings the user to another headline ("hexLIN" not "hexLINSER") as long > as headline "hexLINSER" can be also displayed. > > When using firefox, the top headline is hexLINSER as expected (at least > I do). Yeah, I think its actually chrome that I saw it originally, but that's probably irrelevant. After your re-org, in Chrome, if the window is small enough, I still only see the "3 Open Source Tool: hexLIN" stuff, but that's not an issue with the binding itself, so I won't hold things up on that basis.
diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml new file mode 100644 index 0000000000000..c178eb9be1391 --- /dev/null +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Serial LIN Adapter + +description: + LIN transceiver, mostly hard-wired to a serial device, used for communication + on a LIN bus. + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. + +maintainers: + - Christoph Fritz <christoph.fritz@hexdev.de> + +properties: + compatible: + const: hexdev,lin-serdev + +required: + - compatible + +additionalProperties: false + +examples: + - | + serial { + linbus { + compatible = "hexdev,lin-serdev"; + }; + };
Add dt-bindings for serial LIN bus adapters. These adapters are basically just LIN transceivers that are hard-wired to serial devices. Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> --- .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml