| Message ID | 20240502075534.882628-7-christoph.fritz@hexdev.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LIN Bus support for Linux | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 02/05/2024 09:55, Christoph Fritz wrote: > This patch adds dt-bindings for serial LIN bus adapters. These adapters are Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > basically just LIN transceivers that get hard-wired with serial devices. > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> ... > +maintainers: > + - Christoph Fritz <christoph.fritz@hexdev.de> > + > +properties: > + compatible: > + const: hexdev,lin-serdev > + > +required: > + - compatible > + > +unevaluatedProperties: false This must be additionalProperties: false. Best regards, Krzysztof
On Thu, 02 May 2024 09:55:28 +0200, Christoph Fritz wrote: > This patch adds dt-bindings for serial LIN bus adapters. These adapters are > basically just LIN transceivers that get hard-wired with serial devices. > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > --- > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dtb: /example-0/serial/linbus: failed to match any schema with compatible: ['linux,lin-serdev'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240502075534.882628-7-christoph.fritz@hexdev.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, 2024-05-02 at 04:31 -0500, Rob Herring (Arm) wrote: > On Thu, 02 May 2024 09:55:28 +0200, Christoph Fritz wrote: > > This patch adds dt-bindings for serial LIN bus adapters. These adapters are > > basically just LIN transceivers that get hard-wired with serial devices. > > > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > > --- > > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dtb: /example-0/serial/linbus: failed to match any schema with compatible: ['linux,lin-serdev'] Yes, that's obviously still false and will be fixed in v3. > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240502075534.882628-7-christoph.fritz@hexdev.de > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I'm wondering why my local run of dt_binding_check does not catch this: $ pip3 install dtschema --upgrade Requirement already satisfied: dtschema in ./venv/lib/python3.11/site-packages (2024.4) Requirement already satisfied: ruamel.yaml>0.15.69 in ./venv/lib/python3.11/site-packages (from dtschema) (0.18.6) Requirement already satisfied: jsonschema<4.18,>=4.1.2 in ./venv/lib/python3.11/site-packages (from dtschema) (4.17.3) Requirement already satisfied: rfc3987 in ./venv/lib/python3.11/site-packages (from dtschema) (1.3.8) Requirement already satisfied: pylibfdt in ./venv/lib/python3.11/site-packages (from dtschema) (1.7.0.post1) Requirement already satisfied: attrs>=17.4.0 in ./venv/lib/python3.11/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (23.2.0) Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in ./venv/lib/python3.11/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (0.20.0) Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in ./venv/lib/python3.11/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.8) $ git diff diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml index c178eb9be1391..385cbe132258d 100644 --- a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml @@ -27,6 +27,6 @@ examples: - | serial { linbus { - compatible = "hexdev,lin-serdev"; + compatible = "linux,lin-serdev"; }; }; $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml HOSTCC scripts/basic/fixdep HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/flattree.o HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/data.o HOSTCC scripts/dtc/livetree.o HOSTCC scripts/dtc/treesource.o HOSTCC scripts/dtc/srcpos.o HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTLD scripts/dtc/dtc HOSTCC scripts/dtc/libfdt/fdt.o HOSTCC scripts/dtc/libfdt/fdt_ro.o HOSTCC scripts/dtc/libfdt/fdt_wip.o HOSTCC scripts/dtc/libfdt/fdt_sw.o HOSTCC scripts/dtc/libfdt/fdt_rw.o HOSTCC scripts/dtc/libfdt/fdt_strerror.o HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o HOSTCC scripts/dtc/libfdt/fdt_addresses.o HOSTCC scripts/dtc/libfdt/fdt_overlay.o HOSTCC scripts/dtc/fdtoverlay.o HOSTLD scripts/dtc/fdtoverlay LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json /home/ch/linux/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml: ignoring, error in schema: properties: brcm,tperst-clk-ms: type /home/ch/linux/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml: ignoring, error in schema: properties: emcs205,max-state: description DTEX Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dts DTC_CHK Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dtb Any ideas? I'm using a python venv here, maybe this is related? Thanks -- Christoph
On Thu, May 2, 2024 at 6:03 AM Christoph Fritz <christoph.fritz@hexdev.de> wrote: > > On Thu, 2024-05-02 at 04:31 -0500, Rob Herring (Arm) wrote: > > On Thu, 02 May 2024 09:55:28 +0200, Christoph Fritz wrote: > > > This patch adds dt-bindings for serial LIN bus adapters. These adapters are > > > basically just LIN transceivers that get hard-wired with serial devices. > > > > > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > > > --- > > > .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ > > > 1 file changed, 32 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dtb: /example-0/serial/linbus: failed to match any schema with compatible: ['linux,lin-serdev'] > > Yes, that's obviously still false and will be fixed in v3. > > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240502075534.882628-7-christoph.fritz@hexdev.de > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > I'm wondering why my local run of dt_binding_check does not catch this: > > $ pip3 install dtschema --upgrade > Requirement already satisfied: dtschema in ./venv/lib/python3.11/site-packages (2024.4) > Requirement already satisfied: ruamel.yaml>0.15.69 in ./venv/lib/python3.11/site-packages (from dtschema) (0.18.6) > Requirement already satisfied: jsonschema<4.18,>=4.1.2 in ./venv/lib/python3.11/site-packages (from dtschema) (4.17.3) > Requirement already satisfied: rfc3987 in ./venv/lib/python3.11/site-packages (from dtschema) (1.3.8) > Requirement already satisfied: pylibfdt in ./venv/lib/python3.11/site-packages (from dtschema) (1.7.0.post1) > Requirement already satisfied: attrs>=17.4.0 in ./venv/lib/python3.11/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (23.2.0) > Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in ./venv/lib/python3.11/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (0.20.0) > Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in ./venv/lib/python3.11/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.8) > > $ git diff > diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > index c178eb9be1391..385cbe132258d 100644 > --- a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > @@ -27,6 +27,6 @@ examples: > - | > serial { > linbus { > - compatible = "hexdev,lin-serdev"; > + compatible = "linux,lin-serdev"; > }; > }; > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTLD scripts/dtc/dtc > HOSTCC scripts/dtc/libfdt/fdt.o > HOSTCC scripts/dtc/libfdt/fdt_ro.o > HOSTCC scripts/dtc/libfdt/fdt_wip.o > HOSTCC scripts/dtc/libfdt/fdt_sw.o > HOSTCC scripts/dtc/libfdt/fdt_rw.o > HOSTCC scripts/dtc/libfdt/fdt_strerror.o > HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o > HOSTCC scripts/dtc/libfdt/fdt_addresses.o > HOSTCC scripts/dtc/libfdt/fdt_overlay.o > HOSTCC scripts/dtc/fdtoverlay.o > HOSTLD scripts/dtc/fdtoverlay > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /home/ch/linux/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml: ignoring, error in schema: properties: brcm,tperst-clk-ms: type > /home/ch/linux/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml: ignoring, error in schema: properties: emcs205,max-state: description > DTEX Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dts > DTC_CHK Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.example.dtb > > Any ideas? > > I'm using a python venv here, maybe this is related? No. There are 2 possibilities. What kernel version are you on? This check is enabled with the '-m' option on dt-validate which was only recently (6.9) enabled by default for the bindings. You can enable it with 'DT_CHECKER_FLAGS="-m"'. The other possibility is I noticed that the flag has an interaction with DT_SCHEMA_FILES in that we don't set the flag by default if DT_SCHEMA_FILES is set. (If you explicitly set DT_CHECKER_FLAGS in the newer kernels it should still give the warning.) I think we don't enable it because you would get false positives if your example has compatible strings not documented within the schema you are testing. I need to double check that as how the tools work in this regard has evolved. In any case, DT_SCHEMA_FILES is a shortcut and it is always possible your changes can introduce warnings in other examples, so ultimately "make dt_binding_check" has to be run without DT_SCHEMA_FILES set. Rob
diff --git a/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml new file mode 100644 index 0000000000000..cbf9f63a2a49f --- /dev/null +++ b/Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/can/hexdev,lin-serdev.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Serial LIN Adapter + +description: + LIN transceiver, mostly hard-wired to a serial device, used for communication + on a LIN bus. + For more details on an adapter, visit <https://hexdev.de/hexlin#tty>. + +maintainers: + - Christoph Fritz <christoph.fritz@hexdev.de> + +properties: + compatible: + const: hexdev,lin-serdev + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + serial { + linbus { + compatible = "linux,lin-serdev"; + }; + };
This patch adds dt-bindings for serial LIN bus adapters. These adapters are basically just LIN transceivers that get hard-wired with serial devices. Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> --- .../bindings/net/can/hexdev,lin-serdev.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/hexdev,lin-serdev.yaml