From patchwork Tue Apr 30 04:08:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1929259 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=SUo28tdh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org; envelope-from=devicetree+bounces-63791-incoming-dt=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VT6Bg0k2Tz23jG for ; Tue, 30 Apr 2024 14:08:43 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 352F5282E44 for ; Tue, 30 Apr 2024 04:08:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1DA7F11737; Tue, 30 Apr 2024 04:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="SUo28tdh" X-Original-To: devicetree@vger.kernel.org Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CC6C11185 for ; Tue, 30 Apr 2024 04:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714450116; cv=none; b=fymTxVA/Z5kr6UFlXX/xoxs7HWyInRLh+N8oxDKtPO1C+IkybGdhwlPkTRW8t1OsbnnFGeoOhmm5CFzpLwjc6iO4Awj9iXhKKQNCczBTpChdU0EHD948FIskURoQ20eRSZWCRU1AfoaTA92kuXTxEnEFeC0itdxpdu4PADjmYb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714450116; c=relaxed/simple; bh=tG0gR3luXw6co1uV9l6dsdMa/PsBDGFgb76VFuZxDFA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=adMcrex75mA02BbM+hAuq/4Eoo9XdxiTKaEFmzNAG372w1LJ4CsPTGlZDZxTcz5pQE/rDhaB2EvARFqVVjw5B3naz9wGGF57JJrZGbh2MRCVQLWGL7FG7Z8TdiKYpBQecaO0mn3RddUDR09nLPf81iMb3Oj875UBdDWgs5wf0sE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=SUo28tdh; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-de45dba157cso4894704276.3 for ; Mon, 29 Apr 2024 21:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1714450114; x=1715054914; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gCslZkcQd5RtLXYuX+Nd2JyjWr4Wgb6SjvGmoz0L3zE=; b=SUo28tdhAw0hJRAOpxEmJPb9T4IQL0OQxKfDiiNkLYszBj/tMy6A5IfUEM+a50jiqr 9VwpxQAaxNEtDLE6D01YMjPzEp0FP9v9NrGQ63oCAO3PBP/VxoB/hPu3sd/ECX/HsWxr ff/2z6aZ08hBy8zJtmLLk3zjLX7eaSKRIHyUbT4yzjAap/zwHfVSAmmHATYlMCPlLtgl KFyy7AvRFNBN6YEBp1ZYQuJuKiJbe5iBtX3Eby0X/rplxuDSqnIBaNxoV7rXXHFWawWh KUFTdIrwdGhjrcfwcBHjzK4npeiL5NieLn31xI48OUrxzBFjc0YziAVt1aK6CIK8rN9l DbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714450114; x=1715054914; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gCslZkcQd5RtLXYuX+Nd2JyjWr4Wgb6SjvGmoz0L3zE=; b=ag+yCGwOqiB62eJFcj1l4gv8h3SzWPnxVl6yXCqUpw5lPuzkQjyBTarC6XWFGEB+Bw cfimTxm2kt7NwYdBz/iqws14+t6qeqPRqa2R2wdibj06VcDiM/XSL5bwSqpo9o3XZO07 Ema69KC9lIZc9E5bwhxHiFHOhNBcAcBD8RPmQ/J1OmDbraoHvHVj2xuBnkIkKVIUPVa3 EPJ7BG3/p0A98A9GuNUSreXxjZjUez/azrObFpD//+rnsKEs9tQwJ0T8/RkAEcSUg/fw 0kI6qIbrmtmurkDDW+aW4Ycvrd/leXYbyN9OjR2hw8v/1PEKGsTXpTOLX6OyzLBR4dHT EdVQ== X-Forwarded-Encrypted: i=1; AJvYcCV+N2CLfWxlwXb93uLbt5eCy8aovZxZi1uj7O+7PkGa9FbIgyfmjJ4LJ3yfmQmNin1CeeDA5JK8kkkLtUS2C6DjcYk0rD/2lmcysQ== X-Gm-Message-State: AOJu0YweUm1Yzz0eKD+FH6ihTvd3j0ETiZvP+a9QhmlLcYAIf2hypAa3 dsJRYzLSDGMXdGEjSjp58p/hRt7TuW9ammNc2e3eA3IeOPlDPhJ6zrYOPYju2bM= X-Google-Smtp-Source: AGHT+IFwAJsZsr7vaGkLxE1T7x6+TzNPPDBiFljXpmorJhrntyhYM0B3aRKRclxB5YSlsfW2NRqwOw== X-Received: by 2002:a05:690c:6d03:b0:615:8c1:d7ec with SMTP id iv3-20020a05690c6d0300b0061508c1d7ecmr11997230ywb.33.1714450113146; Mon, 29 Apr 2024 21:08:33 -0700 (PDT) Received: from anup-ubuntu-vm.localdomain ([103.97.165.210]) by smtp.gmail.com with ESMTPSA id i190-20020a0dc6c7000000b00618876dc75fsm5694002ywd.27.2024.04.29.21.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 21:08:32 -0700 (PDT) From: Anup Patel To: Rob Herring , Saravana Kannan Cc: Palmer Dabbelt , Paul Walmsley , Atish Patra , Andrew Jones , Sunil V L , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: [PATCH v3] of: property: Add fw_devlink support for interrupt-map property Date: Tue, 30 Apr 2024 09:38:22 +0530 Message-Id: <20240430040822.1133339-1-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Some of the PCI controllers (such as generic PCI host controller) use "interrupt-map" DT property to describe the mapping between PCI endpoints and PCI interrupt pins. This the only case where the interrupts are not described in DT. Currently, there is no fw_devlink created based on "interrupt-map" DT property so interrupt controller is not guaranteed to be probed before PCI host controller. This affects every platform where both PCI host controller and interrupt controllers are probed as regular platform devices. This creates fw_devlink between consumers (PCI host controller) and supplier (interrupt controller) based on "interrupt-map" DT property. Signed-off-by: Anup Patel Reviewed-by: Saravana Kannan --- Changes since v2: - No need for a loop to find #interrupt-cells property value - Fix node de-reference leak when index is greater than number of entries in interrupt-map property Changes since v1: - Updated commit description based on Rob's suggestion - Use of_irq_parse_raw() for parsing interrupt-map DT property --- drivers/of/property.c | 50 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index a6358ee99b74..7326ca07adfe 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1311,6 +1311,55 @@ static struct device_node *parse_interrupts(struct device_node *np, return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.np; } +static struct device_node *parse_interrupt_map(struct device_node *np, + const char *prop_name, int index) +{ + const __be32 *imap, *imap_end, *addr; + struct of_phandle_args sup_args; + u32 addrcells, intcells; + int i, imaplen; + + if (!IS_ENABLED(CONFIG_OF_IRQ)) + return NULL; + + if (strcmp(prop_name, "interrupt-map")) + return NULL; + + if (of_property_read_u32(np, "#interrupt-cells", &intcells)) + return NULL; + addrcells = of_bus_n_addr_cells(np); + + imap = of_get_property(np, "interrupt-map", &imaplen); + if (!imap || imaplen <= (addrcells + intcells)) + return NULL; + imap_end = imap + imaplen; + + sup_args.np = NULL; + while (imap < imap_end) { + addr = imap; + imap += addrcells; + + sup_args.np = np; + sup_args.args_count = intcells; + for (i = 0; i < intcells; i++) + sup_args.args[i] = be32_to_cpu(imap[i]); + imap += intcells; + + if (of_irq_parse_raw(addr, &sup_args)) + return NULL; + + if (!index) + return sup_args.np; + + of_node_put(sup_args.np); + sup_args.np = NULL; + imap += sup_args.args_count + 1; + index--; + } + + return NULL; +} + static struct device_node *parse_remote_endpoint(struct device_node *np, const char *prop_name, int index) @@ -1359,6 +1408,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_msi_parent, }, { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_interrupts, }, + { .parse_prop = parse_interrupt_map, }, { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, },