| Message ID | 20240430024002.708227-2-liujianfeng1994@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add hantro g1 video decoder support for RK3588 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 9 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi, Le mardi 30 avril 2024 à 10:40 +0800, Jianfeng Liu a écrit : > Add Hantro G1 VPU compatible string for RK3588. > RK3588 has the same Hantro G1 ip as RK3568, which are both > known as VDPU121 in TRM of RK3568 and RK3588. > > Note that this VPU also has a jpeg encoder, which is one part of > the five VEPU121 jpeg encoders on RK3588. So this VPU121 shoud be > the same as vpu@ff650000 on RK3399. But we don't use the compatible > string rk3399-vpu because of two reasons: > 1, rk3399-vpu has disabled H264 decoding because RK3399 also has > rkvdec to support 4K H264 decoding. And we need H264 decoding because > rkvdec2 on rk3588 for H264 decoding is not supported now. > 2, There are five VEPU121 jpeg encoders, but the kernel driver can't > do scheduling. So it's better to disable the VEPU121 jpeg encoder > at the moment. > > Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index c57e1f488..2710bb2fb 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -31,6 +31,9 @@ properties: > - items: > - const: rockchip,rk3228-vpu > - const: rockchip,rk3399-vpu > + - items: > + - const: rockchip,rk3588-vpu121 > + - const: rockchip,rk3568-vpu Sorry to come that late, but I'm noticing a big mistake here. You said you are enabling VDPU121, the JPEG decoder. But we don't have a JPEG decoder driver mainline, is there some patches missing ? Nicolas > > reg: > maxItems: 1 > -- > 2.34.1 >
Sorry, [...] > > + - const: rockchip,rk3568-vpu > > Sorry to come that late, but I'm noticing a big mistake here. You said you are > enabling VDPU121, the JPEG decoder. But we don't have a JPEG decoder driver > mainline, is there some patches missing ? > > Nicolas Ignore this part, just didn't read carefully. This is about getting H264, VP8 and MPEG2 out of these extra cores of course. I still would like to know how we will express the grouping of these four cores, so a driver can know they are identical G1 cores and not bound to be time sliced with an H1 core like the fifth one? I want to see a plan that will work and will not cause headache for future work on fully utilizing the HW resources. Nicolas
diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml index c57e1f488..2710bb2fb 100644 --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml @@ -31,6 +31,9 @@ properties: - items: - const: rockchip,rk3228-vpu - const: rockchip,rk3399-vpu + - items: + - const: rockchip,rk3588-vpu121 + - const: rockchip,rk3568-vpu reg: maxItems: 1