| Message ID | 20240424125850.4189116-2-tgamblin@baylibre.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pwm: add axi-pwm-gen driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 2024-04-24 8:58 a.m., Trevor Gamblin wrote: > From: Drew Fustini <dfustini@baylibre.com> > > Add Analog Devices AXI PWM generator. > > Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen > Signed-off-by: Drew Fustini <dfustini@baylibre.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com> > Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Note that I missed the following two acks from the v4 series when preparing v5: Acked-by: Michael Hennerich<michael.hennerich@analog.com> Acked-by: Nuno Sa<nuno.sa@analog.com> Trevor > --- > v5 changes: > * Modify to list only the supported axi-pwmgen-2.00.a version > > v4 changes: None (rebased, added maintainer's previous Reviewed-by) > v3 changes: None (rebased, added maintainer's previous Reviewed-by) > > v2 changes: > * Address feedback for driver and device tree in v1: > * Relocate "unevaluatedProperties" in device tree binding > * Remove redundant "bindings for" in description > > --- > .../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++ > MAINTAINERS | 8 ++++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > new file mode 100644 > index 000000000000..ec6115d3796b > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AXI PWM generator > + > +maintainers: > + - Michael Hennerich <Michael.Hennerich@analog.com> > + - Nuno Sá <nuno.sa@analog.com> > + > +description: > + The Analog Devices AXI PWM generator can generate PWM signals > + with variable pulse width and period. > + > + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + const: adi,axi-pwmgen-2.00.a > + > + reg: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > + clocks: > + maxItems: 1 > + > +required: > + - reg > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + pwm@44b00000 { > + compatible = "adi,axi-pwmgen-2.00.a"; > + reg = <0x44b00000 0x1000>; > + clocks = <&spi_clk>; > + #pwm-cells = <2>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index ebf03f5f0619..d02ece54ccf6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3465,6 +3465,14 @@ W: https://ez.analog.com/linux-software-drivers > F: Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml > F: drivers/spi/spi-axi-spi-engine.c > > +AXI PWM GENERATOR > +M: Michael Hennerich <michael.hennerich@analog.com> > +M: Nuno Sá <nuno.sa@analog.com> > +L: linux-pwm@vger.kernel.org > +S: Supported > +W: https://ez.analog.com/linux-software-drivers > +F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > + > AXXIA I2C CONTROLLER > M: Krzysztof Adamski <krzysztof.adamski@nokia.com> > L: linux-i2c@vger.kernel.org
On 26/04/2024 22:11, Trevor Gamblin wrote: > > On 2024-04-24 8:58 a.m., Trevor Gamblin wrote: >> From: Drew Fustini <dfustini@baylibre.com> >> >> Add Analog Devices AXI PWM generator. >> >> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen >> Signed-off-by: Drew Fustini <dfustini@baylibre.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com> >> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> > Note that I missed the following two acks from the v4 series when > preparing v5: > > Acked-by: Michael Hennerich<michael.hennerich@analog.com> > Acked-by: Nuno Sa<nuno.sa@analog.com> You cannot add other people's tags that way. By default b4 ignores it. Also, don't modify the tags... Best regards, Krzysztof
Hello Krzysztof, On Mon, Apr 29, 2024 at 08:23:19AM +0200, Krzysztof Kozlowski wrote: > On 26/04/2024 22:11, Trevor Gamblin wrote: > > > > On 2024-04-24 8:58 a.m., Trevor Gamblin wrote: > >> From: Drew Fustini <dfustini@baylibre.com> > >> > >> Add Analog Devices AXI PWM generator. > >> > >> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen > >> Signed-off-by: Drew Fustini <dfustini@baylibre.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com> > >> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> > > Note that I missed the following two acks from the v4 series when > > preparing v5: > > > > Acked-by: Michael Hennerich<michael.hennerich@analog.com> > > Acked-by: Nuno Sa<nuno.sa@analog.com> > > You cannot add other people's tags that way. By default b4 ignores it. I'm aware that I have to pay attention to that detail (i.e. using b4 am -S). Full disclosure: I asked off-list if Trevor missed to add these Acks and requested to add them this way if yes. > Also, don't modify the tags... you mean the missing space between name and email address? I can fix that up when (and if) I apply the patches. Best regards Uwe
diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml new file mode 100644 index 000000000000..ec6115d3796b --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AXI PWM generator + +maintainers: + - Michael Hennerich <Michael.Hennerich@analog.com> + - Nuno Sá <nuno.sa@analog.com> + +description: + The Analog Devices AXI PWM generator can generate PWM signals + with variable pulse width and period. + + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + const: adi,axi-pwmgen-2.00.a + + reg: + maxItems: 1 + + "#pwm-cells": + const: 2 + + clocks: + maxItems: 1 + +required: + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + pwm@44b00000 { + compatible = "adi,axi-pwmgen-2.00.a"; + reg = <0x44b00000 0x1000>; + clocks = <&spi_clk>; + #pwm-cells = <2>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index ebf03f5f0619..d02ece54ccf6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3465,6 +3465,14 @@ W: https://ez.analog.com/linux-software-drivers F: Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml F: drivers/spi/spi-axi-spi-engine.c +AXI PWM GENERATOR +M: Michael Hennerich <michael.hennerich@analog.com> +M: Nuno Sá <nuno.sa@analog.com> +L: linux-pwm@vger.kernel.org +S: Supported +W: https://ez.analog.com/linux-software-drivers +F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml + AXXIA I2C CONTROLLER M: Krzysztof Adamski <krzysztof.adamski@nokia.com> L: linux-i2c@vger.kernel.org