| Message ID | 20240417170054.140587-5-alisa.roman@analog.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: ad7192: Add AD7194 support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 100 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Apr 17, 2024 at 08:00:53PM +0300, Alisa-Dariana Roman wrote: > Unlike the other AD719Xs, AD7194 has configurable differential > channels. The user can dynamically configure them in the devicetree. > > Also add an example for AD7194 devicetree. > > Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com> > --- > .../bindings/iio/adc/adi,ad7192.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > index cf5c568f140a..7e4e15e4e648 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > @@ -21,8 +21,15 @@ properties: > - adi,ad7190 > - adi,ad7192 > - adi,ad7193 > + - adi,ad7194 > - adi,ad7195 > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > reg: > maxItems: 1 > > @@ -89,6 +96,30 @@ properties: > description: see Documentation/devicetree/bindings/iio/adc/adc.yaml > type: boolean > > +patternProperties: > + "^channel@[0-9a-z]+$": Unit-addresses are hex (typically). So something like: '^channel@(100|[0-9a-f]{1,2})$' > + type: object > + $ref: adc.yaml > + unevaluatedProperties: false > + > + properties: > + reg: > + description: The channel index. > + minimum: 1 > + maximum: 256 Why not 0 based? > + > + diff-channels: > + description: | Don't need '|' if no formatting. > + Both inputs can be connected to pins AIN1 to AIN16 by choosing the > + appropriate value from 1 to 16. > + items: > + minimum: 1 > + maximum: 16 > + > + required: > + - reg > + - diff-channels Single ended modes aren't supported? > + > required: > - compatible > - reg > @@ -103,6 +134,17 @@ required: > > allOf: > - $ref: /schemas/spi/spi-peripheral-props.yaml# > + - if: > + properties: > + compatible: > + enum: > + - adi,ad7190 > + - adi,ad7192 > + - adi,ad7193 > + - adi,ad7195 > + then: > + patternProperties: > + "^channel@[0-9a-z]+$": false > > unevaluatedProperties: false > > @@ -133,3 +175,38 @@ examples: > adi,burnout-currents-enable; > }; > }; > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { > + compatible = "adi,ad7194"; > + reg = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + spi-max-frequency = <1000000>; > + spi-cpol; > + spi-cpha; > + clocks = <&ad7192_mclk>; > + clock-names = "mclk"; > + interrupts = <25 0x2>; > + interrupt-parent = <&gpio>; > + aincom-supply = <&aincom>; > + dvdd-supply = <&dvdd>; > + avdd-supply = <&avdd>; > + vref-supply = <&vref>; > + > + channel@1 { > + reg = <1>; > + diff-channels = <1 6>; > + }; > + > + channel@2 { > + reg = <2>; > + diff-channels = <16 5>; > + }; > + }; > + }; > -- > 2.34.1 >
On Thu, 18 Apr 2024 09:40:19 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, Apr 17, 2024 at 08:00:53PM +0300, Alisa-Dariana Roman wrote: > > Unlike the other AD719Xs, AD7194 has configurable differential > > channels. The user can dynamically configure them in the devicetree. > > > > Also add an example for AD7194 devicetree. > > > > Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com> More general follow up comment inline. > > --- > > .../bindings/iio/adc/adi,ad7192.yaml | 77 +++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > index cf5c568f140a..7e4e15e4e648 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > @@ -21,8 +21,15 @@ properties: > > - adi,ad7190 > > - adi,ad7192 > > - adi,ad7193 > > + - adi,ad7194 > > - adi,ad7195 > > > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > reg: > > maxItems: 1 > > > > @@ -89,6 +96,30 @@ properties: > > description: see Documentation/devicetree/bindings/iio/adc/adc.yaml > > type: boolean > > > > +patternProperties: > > + "^channel@[0-9a-z]+$": > > Unit-addresses are hex (typically). So something like: > > '^channel@(100|[0-9a-f]{1,2})$' > > > + type: object > > + $ref: adc.yaml > > + unevaluatedProperties: false > > + > > + properties: > > + reg: > > + description: The channel index. > > + minimum: 1 > > + maximum: 256 > > Why not 0 based? > > > > + > > + diff-channels: > > + description: | > > Don't need '|' if no formatting. > > > + Both inputs can be connected to pins AIN1 to AIN16 by choosing the > > + appropriate value from 1 to 16. > > + items: > > + minimum: 1 > > + maximum: 16 > > + > > + required: > > + - reg > > + - diff-channels > > Single ended modes aren't supported? To follow up on this. For single ended only devices we just let reg reference the the channel. For differential channels that never worked (because there was a pair). So for mixed devices it's a bit of a mess. I'd be happy if we cleaned that up by adding a binding alongside diff-channels that was simply channel. For single ended only devices it would be optional but it would make this device and similar easier to describe. We can wrap it up in a helper function that queries channel first and falls back to reg if it isn't there. Maybe could call it single-channel to make it obvious it's an either or with diff-channels. With hindsight we could have just made that take 1 or 2 elements and given it a generic name from the start. Ah the wonder if retro designing interfaces... :( New element in adc.yaml would looks something like. single-channel: $ref: /schemas/types.yaml#/definitions/uint32 description: When devices combine single and differential channels, allow the channel for a single element to be specified, independent of reg (as for differentila channels). If this and diff-channels are not present reg shall be used instead. Jonathan > > > + > > required: > > - compatible > > - reg > > @@ -103,6 +134,17 @@ required: > > > > allOf: > > - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + - if: > > + properties: > > + compatible: > > + enum: > > + - adi,ad7190 > > + - adi,ad7192 > > + - adi,ad7193 > > + - adi,ad7195 > > + then: > > + patternProperties: > > + "^channel@[0-9a-z]+$": false > > > > unevaluatedProperties: false > > > > @@ -133,3 +175,38 @@ examples: > > adi,burnout-currents-enable; > > }; > > }; > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + adc@0 { > > + compatible = "adi,ad7194"; > > + reg = <0>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + spi-max-frequency = <1000000>; > > + spi-cpol; > > + spi-cpha; > > + clocks = <&ad7192_mclk>; > > + clock-names = "mclk"; > > + interrupts = <25 0x2>; > > + interrupt-parent = <&gpio>; > > + aincom-supply = <&aincom>; > > + dvdd-supply = <&dvdd>; > > + avdd-supply = <&avdd>; > > + vref-supply = <&vref>; > > + > > + channel@1 { > > + reg = <1>; > > + diff-channels = <1 6>; > > + }; > > + > > + channel@2 { > > + reg = <2>; > > + diff-channels = <16 5>; > > + }; > > + }; > > + }; > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml index cf5c568f140a..7e4e15e4e648 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml @@ -21,8 +21,15 @@ properties: - adi,ad7190 - adi,ad7192 - adi,ad7193 + - adi,ad7194 - adi,ad7195 + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + reg: maxItems: 1 @@ -89,6 +96,30 @@ properties: description: see Documentation/devicetree/bindings/iio/adc/adc.yaml type: boolean +patternProperties: + "^channel@[0-9a-z]+$": + type: object + $ref: adc.yaml + unevaluatedProperties: false + + properties: + reg: + description: The channel index. + minimum: 1 + maximum: 256 + + diff-channels: + description: | + Both inputs can be connected to pins AIN1 to AIN16 by choosing the + appropriate value from 1 to 16. + items: + minimum: 1 + maximum: 16 + + required: + - reg + - diff-channels + required: - compatible - reg @@ -103,6 +134,17 @@ required: allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# + - if: + properties: + compatible: + enum: + - adi,ad7190 + - adi,ad7192 + - adi,ad7193 + - adi,ad7195 + then: + patternProperties: + "^channel@[0-9a-z]+$": false unevaluatedProperties: false @@ -133,3 +175,38 @@ examples: adi,burnout-currents-enable; }; }; + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + compatible = "adi,ad7194"; + reg = <0>; + + #address-cells = <1>; + #size-cells = <0>; + + spi-max-frequency = <1000000>; + spi-cpol; + spi-cpha; + clocks = <&ad7192_mclk>; + clock-names = "mclk"; + interrupts = <25 0x2>; + interrupt-parent = <&gpio>; + aincom-supply = <&aincom>; + dvdd-supply = <&dvdd>; + avdd-supply = <&avdd>; + vref-supply = <&vref>; + + channel@1 { + reg = <1>; + diff-channels = <1 6>; + }; + + channel@2 { + reg = <2>; + diff-channels = <16 5>; + }; + }; + };
Unlike the other AD719Xs, AD7194 has configurable differential channels. The user can dynamically configure them in the devicetree. Also add an example for AD7194 devicetree. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com> --- .../bindings/iio/adc/adi,ad7192.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+)