diff mbox series

[2/4] regulator: dt-bindings: pca9450: add pca9451a support

Message ID 20240417153528.7838-3-fabio.aiuto@engicam.com
State Not Applicable
Headers show
Series arm64: dts: imx93: add i.Core MX93 EDIMM 2.0 board | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Aiuto April 17, 2024, 3:35 p.m. UTC 
Update bindings for pca9451a support.

Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
---
 .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml     | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski April 17, 2024, 5:04 p.m. UTC | #1 
On 17/04/2024 17:35, Fabio Aiuto wrote:
> Update bindings for pca9451a support.
> 
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
> ---


Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Mark Brown April 18, 2024, 12:38 a.m. UTC | #2 
On Wed, Apr 17, 2024 at 05:35:26PM +0200, Fabio Aiuto wrote:
> Update bindings for pca9451a support.

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code.  Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
Fabio Aiuto April 18, 2024, 7:26 a.m. UTC | #3 
Dear Mark,

Il Thu, Apr 18, 2024 at 09:38:06AM +0900, Mark Brown ha scritto:
> On Wed, Apr 17, 2024 at 05:35:26PM +0200, Fabio Aiuto wrote:
> > Update bindings for pca9451a support.
> 
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.  Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.

thank you, I was in doubt because I did the whole job based on
shawnguo's repo where the patch isn't applied yet.

Maybe this approach was not good, should I have considered broonie's
repo for this single patch, shouldn't I?

Anyway I'm dropping this patch for a v2.

kr,

fabio
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index 3d469b8e9774..849bfa50bdba 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -28,6 +28,7 @@  properties:
       - nxp,pca9450a
       - nxp,pca9450b
       - nxp,pca9450c
+      - nxp,pca9451a
 
   reg:
     maxItems: 1