diff mbox series

[v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible

Message ID 20240417045207.3594931-1-github.com@herrie.org
State Superseded
Headers show
Series [v2] dt-bindings: phy: qcom,usb-hs-phy: Add compatible | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dt-meta-schema fail build log

Commit Message

Herman van Hazendonk April 17, 2024, 4:52 a.m. UTC
Adds qcom,usb-hs-phy-msm8660 compatible

Used by HP Touchpad (tenderloin) for example.

Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
---
 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Baryshkov April 17, 2024, 5:57 a.m. UTC | #1
On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk
<github.com@herrie.org> wrote:
>
> Adds qcom,usb-hs-phy-msm8660 compatible
>
> Used by HP Touchpad (tenderloin) for example.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> index f042d6af1594..ccf23170cd17 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> @@ -15,6 +15,7 @@ if:
>        contains:
>          enum:
>            - qcom,usb-hs-phy-apq8064
> +          - qcom,usb-hs-phy-msm8660
>            - qcom,usb-hs-phy-msm8960
>  then:
>    properties:
> @@ -41,6 +42,7 @@ properties:
>        - enum:
>            - qcom,usb-hs-phy-apq8064
>            - qcom,usb-hs-phy-msm8226
> +          - qcom,usb-hs-phy-msm8960

This should probably be msm8660 rather than 8960

Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy
compatible, but I wonder if we should enforce this for such an old
platform or whether similarity wins.

>            - qcom,usb-hs-phy-msm8916
>            - qcom,usb-hs-phy-msm8960
>            - qcom,usb-hs-phy-msm8974
>
Herman van Hazendonk April 17, 2024, 6:50 a.m. UTC | #2
On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk
<github.com@herrie.org> wrote:
>>
>> Adds qcom,usb-hs-phy-msm8660 compatible
>>
>> Used by HP Touchpad (tenderloin) for example.
>>
>> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
>> ---
>>  Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
>> index f042d6af1594..ccf23170cd17 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
>> @@ -15,6 +15,7 @@ if:
>>        contains:
>>          enum:
>>            - qcom,usb-hs-phy-apq8064
>> +          - qcom,usb-hs-phy-msm8660
>>            - qcom,usb-hs-phy-msm8960
>>  then:
>>    properties:
>> @@ -41,6 +42,7 @@ properties:
>>        - enum:
>>            - qcom,usb-hs-phy-apq8064
>>            - qcom,usb-hs-phy-msm8226
>> +          - qcom,usb-hs-phy-msm8960

> This should probably be msm8660 rather than 8960
Hi Dmitry,

Thanks for the swift feedback. I'll send a v3.
I need more coffee before doing this in the morning

> Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy
> compatible, but I wonder if we should enforce this for such an old
> platform or whether similarity wins.

>>            - qcom,usb-hs-phy-msm8916
>>            - qcom,usb-hs-phy-msm8960
>>            - qcom,usb-hs-phy-msm8974
>>

I plan to send more patches for the msm8660, so happy to understand what
is the preferred approach, because it doesn't seem consistent.

These are my first patches, so learning mainly from what I see in commit
history (which might be outdated)
It's indeed ancient platform, we just would like to get HP TouchPad
(tenderloin) running with a mainline kernel, hence these patches.

Best regards,
Herman

> --
> With best wishes
> Dmitry
Dmitry Baryshkov April 17, 2024, 7:02 a.m. UTC | #3
On Wed, 17 Apr 2024 at 09:50, Herman van Hazendonk
<github.com@herrie.org> wrote:
>
> On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk
> <github.com@herrie.org> wrote:
> >>
> >> Adds qcom,usb-hs-phy-msm8660 compatible
> >>
> >> Used by HP Touchpad (tenderloin) for example.
> >>
> >> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> >> ---
> >>  Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> >> index f042d6af1594..ccf23170cd17 100644
> >> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> >> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
> >> @@ -15,6 +15,7 @@ if:
> >>        contains:
> >>          enum:
> >>            - qcom,usb-hs-phy-apq8064
> >> +          - qcom,usb-hs-phy-msm8660
> >>            - qcom,usb-hs-phy-msm8960
> >>  then:
> >>    properties:
> >> @@ -41,6 +42,7 @@ properties:
> >>        - enum:
> >>            - qcom,usb-hs-phy-apq8064
> >>            - qcom,usb-hs-phy-msm8226
> >> +          - qcom,usb-hs-phy-msm8960
>
> > This should probably be msm8660 rather than 8960
> Hi Dmitry,
>
> Thanks for the swift feedback. I'll send a v3.
> I need more coffee before doing this in the morning

Please wait for the feedback from bindings maintainers (this might
take a couple of days).

> > Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy
> > compatible, but I wonder if we should enforce this for such an old
> > platform or whether similarity wins.
>
> >>            - qcom,usb-hs-phy-msm8916
> >>            - qcom,usb-hs-phy-msm8960
> >>            - qcom,usb-hs-phy-msm8974
> >>
>
> I plan to send more patches for the msm8660, so happy to understand what
> is the preferred approach, because it doesn't seem consistent.
>
> These are my first patches, so learning mainly from what I see in commit
> history (which might be outdated)
> It's indeed ancient platform, we just would like to get HP TouchPad
> (tenderloin) running with a mainline kernel, hence these patches.

This sounds really interesting. I recently got apq8060 so I should be
able to test your patches if the time permits.
Krzysztof Kozlowski April 17, 2024, 7:03 p.m. UTC | #4
On 17/04/2024 06:52, Herman van Hazendonk wrote:
> Adds qcom,usb-hs-phy-msm8660 compatible
> 
> Used by HP Touchpad (tenderloin) for example.
> 
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
index f042d6af1594..ccf23170cd17 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
@@ -15,6 +15,7 @@  if:
       contains:
         enum:
           - qcom,usb-hs-phy-apq8064
+          - qcom,usb-hs-phy-msm8660
           - qcom,usb-hs-phy-msm8960
 then:
   properties:
@@ -41,6 +42,7 @@  properties:
       - enum:
           - qcom,usb-hs-phy-apq8064
           - qcom,usb-hs-phy-msm8226
+          - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8916
           - qcom,usb-hs-phy-msm8960
           - qcom,usb-hs-phy-msm8974