| Message ID | 20240415151645.1986014-1-github.com@herrie.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote: > The FLT pin was incorrected documented as an output. The MAX8903 uses it to > signal to the processor that a charging fault has occurred. I guess this is just a matter of framing? Input to the hardware running the OS but an output from the max8903? I'm okay with whatever wording causing less confusion, which may mean something that specifics what this is relative to? > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> The SoB email should match the from email fyi. Cheers, Conor. > --- > .../devicetree/bindings/power/supply/maxim,max8903.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > index a8d625f285f1..86af38378999 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > @@ -34,7 +34,7 @@ properties: > > flt-gpios: > maxItems: 1 > - description: Fault pin (active low, output) > + description: Fault pin (active low, input) > > dcm-gpios: > maxItems: 1
On Mon, 15 Apr 2024 17:16:45 +0200, Herman van Hazendonk wrote: > The FLT pin was incorrected documented as an output. The MAX8903 uses it to > signal to the processor that a charging fault has occurred. > > Applied, thanks! [1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input commit: 55f7073f6f59ef2c9e98b70f74118dba62e1aabc Best regards,
Hi, On Mon, Apr 15, 2024 at 05:28:22PM +0100, Conor Dooley wrote: > On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote: > > The FLT pin was incorrected documented as an output. The MAX8903 uses it to > > signal to the processor that a charging fault has occurred. > > I guess this is just a matter of framing? Input to the hardware running > the OS but an output from the max8903? > > I'm okay with whatever wording causing less confusion, which may mean > something that specifics what this is relative to? well, this definitely improves things, since the other GPIOs from the same file are all described with the hardware running the OS being the reference. So this makes things at least uniform. > > > > Signed-off-by: Herman van Hazendonk <github.com@herrie.org> > > The SoB email should match the from email fyi. It does for this patch, so I took it. Greetings, -- Sebastian > Cheers, > Conor. > > > --- > > .../devicetree/bindings/power/supply/maxim,max8903.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > > index a8d625f285f1..86af38378999 100644 > > --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml > > @@ -34,7 +34,7 @@ properties: > > > > flt-gpios: > > maxItems: 1 > > - description: Fault pin (active low, output) > > + description: Fault pin (active low, input) > > > > dcm-gpios: > > maxItems: 1
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml index a8d625f285f1..86af38378999 100644 --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml @@ -34,7 +34,7 @@ properties: flt-gpios: maxItems: 1 - description: Fault pin (active low, output) + description: Fault pin (active low, input) dcm-gpios: maxItems: 1
The FLT pin was incorrected documented as an output. The MAX8903 uses it to signal to the processor that a charging fault has occurred. Signed-off-by: Herman van Hazendonk <github.com@herrie.org> --- .../devicetree/bindings/power/supply/maxim,max8903.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)