| Message ID | 20240412110318.273791-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/1] dt-bindings: interrupt-controller: fsl,irqsteer: Add imx8qxp support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 12/04/2024 13:03, Alexander Stein wrote: > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific > compatible, which also requires a power-domain. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > This patch replaces v1 from [1]. > > Changes in v2: > * Add imx8qxp specific compatible > * Require a power-domain for this SoC > > [1] https://lore.kernel.org/all/20240110094338.472304-1-alexander.stein@ew.tq-group.com/ > .../interrupt-controller/fsl,irqsteer.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml > index 20ad4ad82ad6..0ce0246870c0 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml > @@ -14,7 +14,9 @@ properties: > oneOf: > - const: fsl,imx-irqsteer > - items: > - - const: fsl,imx8m-irqsteer > + - enum: > + - fsl,imx8m-irqsteer > + - fsl,imx8qxp-irqsteer > - const: fsl,imx-irqsteer > > reg: > @@ -42,6 +44,9 @@ properties: > clock-names: > const: ipg > > + power-domains: > + maxItems: 1 > + > interrupt-controller: true > > "#interrupt-cells": > @@ -72,6 +77,19 @@ required: > > additionalProperties: false > > +allOf: Put allOf before additionalProperties, just like in example-schema. > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qxp-irqsteer > + then: > + properties: > + power-domains: > + minItems: 1 That's redundant. Drop. > + required: > + - power-domains > + > examples: > - | > #include <dt-bindings/clock/imx8mq-clock.h> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml index 20ad4ad82ad6..0ce0246870c0 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml @@ -14,7 +14,9 @@ properties: oneOf: - const: fsl,imx-irqsteer - items: - - const: fsl,imx8m-irqsteer + - enum: + - fsl,imx8m-irqsteer + - fsl,imx8qxp-irqsteer - const: fsl,imx-irqsteer reg: @@ -42,6 +44,9 @@ properties: clock-names: const: ipg + power-domains: + maxItems: 1 + interrupt-controller: true "#interrupt-cells": @@ -72,6 +77,19 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + const: fsl,imx8qxp-irqsteer + then: + properties: + power-domains: + minItems: 1 + required: + - power-domains + examples: - | #include <dt-bindings/clock/imx8mq-clock.h>
Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific compatible, which also requires a power-domain. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- This patch replaces v1 from [1]. Changes in v2: * Add imx8qxp specific compatible * Require a power-domain for this SoC [1] https://lore.kernel.org/all/20240110094338.472304-1-alexander.stein@ew.tq-group.com/ .../interrupt-controller/fsl,irqsteer.yaml | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)