| Message ID | 20240411-esai_arm_dts_warning-v1-1-5e1a7c7be9b9@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm: dts: nxp: imx6: fix esai related dtb_check warning | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Thu, Apr 11, 2024 at 01:07:45PM -0400, Frank Li wrote: > fsl,fifo-depth have default value 64 in driver(sound/soc/fsl/fsl_esai.c). > > fsl,esai-synchronous is flag(bool) type. It doesn't make sense to put flag > type into 'required'. > > Fix warning: > > arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,fifo-depth' is a required property > arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,esai-synchronous' is a required property > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/sound/fsl,esai.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,esai.yaml b/Documentation/devicetree/bindings/sound/fsl,esai.yaml > index f167f1634d7e3..66f20ecaa42b4 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,esai.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,esai.yaml > @@ -70,7 +70,7 @@ properties: > description: > The number of elements in the transmit and receive > FIFOs. This number is the maximum allowed value for > - TFCR[TFWM] or RFCR[RFWM]. > + TFCR[TFWM] or RFCR[RFWM]. Default value is 64. default: 64 > > fsl,esai-synchronous: > $ref: /schemas/types.yaml#/definitions/flag > @@ -95,8 +95,6 @@ required: > - clock-names > - dmas > - dma-names > - - fsl,fifo-depth > - - fsl,esai-synchronous > > unevaluatedProperties: false > > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/sound/fsl,esai.yaml b/Documentation/devicetree/bindings/sound/fsl,esai.yaml index f167f1634d7e3..66f20ecaa42b4 100644 --- a/Documentation/devicetree/bindings/sound/fsl,esai.yaml +++ b/Documentation/devicetree/bindings/sound/fsl,esai.yaml @@ -70,7 +70,7 @@ properties: description: The number of elements in the transmit and receive FIFOs. This number is the maximum allowed value for - TFCR[TFWM] or RFCR[RFWM]. + TFCR[TFWM] or RFCR[RFWM]. Default value is 64. fsl,esai-synchronous: $ref: /schemas/types.yaml#/definitions/flag @@ -95,8 +95,6 @@ required: - clock-names - dmas - dma-names - - fsl,fifo-depth - - fsl,esai-synchronous unevaluatedProperties: false
fsl,fifo-depth have default value 64 in driver(sound/soc/fsl/fsl_esai.c). fsl,esai-synchronous is flag(bool) type. It doesn't make sense to put flag type into 'required'. Fix warning: arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,fifo-depth' is a required property arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,esai-synchronous' is a required property Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/sound/fsl,esai.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)