| Message ID | 20240410-rtc_dtschema-v2-2-d32a11ab0745@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | rtc: convert multiple bindings into dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 41 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 10/04/2024 17:55, Javier Carrasco wrote: > Convert existing binding to dtschema to support validation. > > Add the undocumented 'clocks' property. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- > .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 15 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: > Convert existing binding to dtschema to support validation. > > Add the undocumented 'clocks' property. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- > .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt > deleted file mode 100644 > index a87a1e9bc060..000000000000 > --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt > +++ /dev/null > @@ -1,15 +0,0 @@ > -* NXP LPC32xx SoC Real Time Clock controller > - > -Required properties: > -- compatible: must be "nxp,lpc3220-rtc" > -- reg: physical base address of the controller and length of memory mapped > - region. > -- interrupts: The RTC interrupt > - > -Example: > - > - rtc@40024000 { > - compatible = "nxp,lpc3220-rtc"; > - reg = <0x40024000 0x1000>; > - interrupts = <52 0>; > - }; > diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml > new file mode 100644 > index 000000000000..62ddeef961e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP LPC32xx SoC Real Time Clock > + > +maintainers: > + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + const: nxp,lpc3220-rtc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 As I explained the clock doesn't really exist, there is no control over it, it is a fixed 32768 Hz crystal, there is no point in describing it as this is already the input clock of the SoC.
On 4/10/24 22:43, Alexandre Belloni wrote: > On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> Add the undocumented 'clocks' property. >> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> >> --- >> .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- >> .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ >> 2 files changed, 41 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> deleted file mode 100644 >> index a87a1e9bc060..000000000000 >> --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -* NXP LPC32xx SoC Real Time Clock controller >> - >> -Required properties: >> -- compatible: must be "nxp,lpc3220-rtc" >> -- reg: physical base address of the controller and length of memory mapped >> - region. >> -- interrupts: The RTC interrupt >> - >> -Example: >> - >> - rtc@40024000 { >> - compatible = "nxp,lpc3220-rtc"; >> - reg = <0x40024000 0x1000>; >> - interrupts = <52 0>; >> - }; >> diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> new file mode 100644 >> index 000000000000..62ddeef961e9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> @@ -0,0 +1,41 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP LPC32xx SoC Real Time Clock >> + >> +maintainers: >> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> >> + >> +allOf: >> + - $ref: rtc.yaml# >> + >> +properties: >> + compatible: >> + const: nxp,lpc3220-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 > > As I explained the clock doesn't really exist, there is no control over > it, it is a fixed 32768 Hz crystal, there is no point in describing it > as this is already the input clock of the SoC. > > In that case the first approach was right, and it should be moved to trivial-rtc. I made the mistake of mentioning the driver and what it does not support, but strictly talking about the device description, the 'clocks' property was pointless in the dts where it was added. If we leave it undocumented, the error I discussed with Krzysztof will have to stay unless the 'clocks' property gets removed from the dts. Best regards, Javier Carrasco
On 10/04/2024 22:43, Alexandre Belloni wrote: > On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> Add the undocumented 'clocks' property. >> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> >> --- >> .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- >> .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ >> 2 files changed, 41 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> deleted file mode 100644 >> index a87a1e9bc060..000000000000 >> --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -* NXP LPC32xx SoC Real Time Clock controller >> - >> -Required properties: >> -- compatible: must be "nxp,lpc3220-rtc" >> -- reg: physical base address of the controller and length of memory mapped >> - region. >> -- interrupts: The RTC interrupt >> - >> -Example: >> - >> - rtc@40024000 { >> - compatible = "nxp,lpc3220-rtc"; >> - reg = <0x40024000 0x1000>; >> - interrupts = <52 0>; >> - }; >> diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> new file mode 100644 >> index 000000000000..62ddeef961e9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> @@ -0,0 +1,41 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP LPC32xx SoC Real Time Clock >> + >> +maintainers: >> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> >> + >> +allOf: >> + - $ref: rtc.yaml# >> + >> +properties: >> + compatible: >> + const: nxp,lpc3220-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 > > As I explained the clock doesn't really exist, there is no control over > it, it is a fixed 32768 Hz crystal, there is no point in describing it > as this is already the input clock of the SoC. That's common for many SoCs but it is still (at least for them) input to the RTC. On some SoC boards 32 kHz is controllable. But if you think it is not correct here, then we should drop it from DTS. Best regards, Krzysztof
On 11/04/2024 08:17:55+0200, Krzysztof Kozlowski wrote: > On 10/04/2024 22:43, Alexandre Belloni wrote: > > On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: > >> Convert existing binding to dtschema to support validation. > >> > >> Add the undocumented 'clocks' property. > >> > >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > >> --- > >> .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- > >> .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ > >> 2 files changed, 41 insertions(+), 15 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt > >> deleted file mode 100644 > >> index a87a1e9bc060..000000000000 > >> --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt > >> +++ /dev/null > >> @@ -1,15 +0,0 @@ > >> -* NXP LPC32xx SoC Real Time Clock controller > >> - > >> -Required properties: > >> -- compatible: must be "nxp,lpc3220-rtc" > >> -- reg: physical base address of the controller and length of memory mapped > >> - region. > >> -- interrupts: The RTC interrupt > >> - > >> -Example: > >> - > >> - rtc@40024000 { > >> - compatible = "nxp,lpc3220-rtc"; > >> - reg = <0x40024000 0x1000>; > >> - interrupts = <52 0>; > >> - }; > >> diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml > >> new file mode 100644 > >> index 000000000000..62ddeef961e9 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml > >> @@ -0,0 +1,41 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: NXP LPC32xx SoC Real Time Clock > >> + > >> +maintainers: > >> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > >> + > >> +allOf: > >> + - $ref: rtc.yaml# > >> + > >> +properties: > >> + compatible: > >> + const: nxp,lpc3220-rtc > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + clocks: > >> + maxItems: 1 > > > > As I explained the clock doesn't really exist, there is no control over > > it, it is a fixed 32768 Hz crystal, there is no point in describing it > > as this is already the input clock of the SoC. > > That's common for many SoCs but it is still (at least for them) input to > the RTC. On some SoC boards 32 kHz is controllable. > There is n way this can be controlled at the board level as the soc mandates a crystal. There is a control for the oscillator but it is not functional. This would be bit 5 of RTC_CTRL which is documented as such: "5 Not used. Write is don’t care, Read returns random value." Even so, the clock wouldn't be an input to the RTC but it is provided by the RTC. I guess because it was easer to d so, the clock is defined in the clock controller driver: https://elixir.bootlin.com/linux/latest/source/drivers/clk/nxp/clk-lpc32xx.c#L1222 but, from an HW point of view, this is not correct.
diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt deleted file mode 100644 index a87a1e9bc060..000000000000 --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt +++ /dev/null @@ -1,15 +0,0 @@ -* NXP LPC32xx SoC Real Time Clock controller - -Required properties: -- compatible: must be "nxp,lpc3220-rtc" -- reg: physical base address of the controller and length of memory mapped - region. -- interrupts: The RTC interrupt - -Example: - - rtc@40024000 { - compatible = "nxp,lpc3220-rtc"; - reg = <0x40024000 0x1000>; - interrupts = <52 0>; - }; diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml new file mode 100644 index 000000000000..62ddeef961e9 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP LPC32xx SoC Real Time Clock + +maintainers: + - Javier Carrasco <javier.carrasco.cruz@gmail.com> + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + const: nxp,lpc3220-rtc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + rtc@40024000 { + compatible = "nxp,lpc3220-rtc"; + reg = <0x40024000 0x1000>; + interrupts = <52 0>; + };
Convert existing binding to dtschema to support validation. Add the undocumented 'clocks' property. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ 2 files changed, 41 insertions(+), 15 deletions(-)