| Message ID | 20240405090118.582310-2-neeraj.sanjaykale@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btnxpuart: Update firmware names | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 05/04/2024 11:01, Neeraj Sanjay Kale wrote: > This adds a new optional device tree property called firware-name. > If this property is specified, the driver overrides the firmware > name hardcoded in the driver source code. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > index f01a3988538c..25c258212bcd 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > @@ -31,6 +31,13 @@ properties: > This property depends on the module vendor's > configuration. > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string drop, missing maxItems. Look at recent code. > + description: > + Specify firmware file name, prepended with nxp/. Why with nxp? What if firmware is stored somewhere else? > + This property overrides the firmware names hardcoded > + in the driver source code. Drop, you now describe current OS policy. What if U-boot treats it differently? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml index f01a3988538c..25c258212bcd 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml @@ -31,6 +31,13 @@ properties: This property depends on the module vendor's configuration. + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Specify firmware file name, prepended with nxp/. + This property overrides the firmware names hardcoded + in the driver source code. + required: - compatible @@ -42,5 +49,6 @@ examples: bluetooth { compatible = "nxp,88w8987-bt"; fw-init-baudrate = <3000000>; + firmware-name = "nxp/uartuart8987_bt_v0.bin"; }; };
This adds a new optional device tree property called firware-name. If this property is specified, the driver overrides the firmware name hardcoded in the driver source code. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)