diff mbox series

[v2,1/2] dt-bindings: mfd: Add ROHM BD71879

Message ID 20240404195423.666446-2-andreas@kemnade.info
State Not Applicable
Headers show
Series mfd: Add ROHM BD71879 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Andreas Kemnade April 4, 2024, 7:54 p.m. UTC
As this chip was seen in several devices in the wild, add it.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
 .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml         | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 5, 2024, 6:56 a.m. UTC | #1
On 04/04/2024 21:54, Andreas Kemnade wrote:
> As this chip was seen in several devices in the wild, add it.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
>  .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml         | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Conor Dooley April 10, 2024, 10:03 a.m. UTC | #2
On Wed, Apr 10, 2024 at 10:57:08AM +0300, Matti Vaittinen wrote:
> On 4/4/24 22:54, Andreas Kemnade wrote:
> > As this chip was seen in several devices in the wild, add it.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> > ---
> >   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml         | 7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > index 0b62f854bf6b..07f99738fcf6 100644
> > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > @@ -17,7 +17,12 @@ description: |
> >   properties:
> >     compatible:
> > -    const: rohm,bd71828
> > +    oneOf:
> > +      - const: rohm,bd71828
> > +
> > +      - items:
> > +          - const: rohm,bd71879
> > +          - const: rohm,bd71828
> >     reg:
> >       description:
> 
> Am I correct, this reads as:
> 
> Either
> 	compatible = rohm,bd71828
> or
> 	compatible = rohm,bd71879, rohm,bd71828
> 
> but not compatible = rohm,bd71879?

Correct.
Lee Jones April 11, 2024, 4:31 p.m. UTC | #3
On Thu, 04 Apr 2024 21:54:22 +0200, Andreas Kemnade wrote:
> As this chip was seen in several devices in the wild, add it.
> 
> 

Applied, thanks!

[1/2] dt-bindings: mfd: Add ROHM BD71879
      commit: 9814ee9b64c06aae57c8a8f003014b3d90e09a3d

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
index 0b62f854bf6b..07f99738fcf6 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
@@ -17,7 +17,12 @@  description: |
 
 properties:
   compatible:
-    const: rohm,bd71828
+    oneOf:
+      - const: rohm,bd71828
+
+      - items:
+          - const: rohm,bd71879
+          - const: rohm,bd71828
 
   reg:
     description: