| Message ID | 20240329235033.25309-3-andre.przywara@arm.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | regulator: Fix AXP717 PMIC support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30/03/2024 00:50, Andre Przywara wrote: > The X-Powers AXP717 contains a boost regulator, that it meant to provide > the 5V USB VBUS voltage when the devices operates on battery. > > Add the name "boost" to the regexp describing the allowed node names, > to allow the regulator to be described in the devicetree. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index b8e8db0d58e9c..14ab367fc8871 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -274,7 +274,7 @@ properties: > Defines the work frequency of DC-DC in kHz. > > patternProperties: > - "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$": > + "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo|boost)$": That's not an easy to read regex... Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> If driver does not depend on _, please consider dropping (_|-). Best regards, Krzysztof
On Sat, 30 Mar 2024 10:30:05 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: Hi, > On 30/03/2024 00:50, Andre Przywara wrote: > > The X-Powers AXP717 contains a boost regulator, that it meant to provide > > the 5V USB VBUS voltage when the devices operates on battery. > > > > Add the name "boost" to the regexp describing the allowed node names, > > to allow the regulator to be described in the devicetree. > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > index b8e8db0d58e9c..14ab367fc8871 100644 > > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > @@ -274,7 +274,7 @@ properties: > > Defines the work frequency of DC-DC in kHz. > > > > patternProperties: > > - "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$": > > + "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo|boost)$": > > That's not an easy to read regex... TBH regexps are the least of my problems when reading bindings ;-) > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks! > If driver does not depend on _, please consider dropping (_|-). The drivers (checked both Linux and FreeBSD) do look for a specific string, but it's the real old regulators that used ldo_io[01] and rtc_ldo, all the "newer" ones use a dash. Since this binding covers all of them, we can't drop this from this regexp, but rest assured we only go with dashes for new and upcoming devices. Thanks, Andre
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml index b8e8db0d58e9c..14ab367fc8871 100644 --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml @@ -274,7 +274,7 @@ properties: Defines the work frequency of DC-DC in kHz. patternProperties: - "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$": + "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo|boost)$": $ref: /schemas/regulator/regulator.yaml# type: object unevaluatedProperties: false
The X-Powers AXP717 contains a boost regulator, that it meant to provide the 5V USB VBUS voltage when the devices operates on battery. Add the name "boost" to the regexp describing the allowed node names, to allow the regulator to be described in the devicetree. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)