| Message ID | 20240329071948.3101882-2-quic_kriskura@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add gpio-usb-c-connector compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 9 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Mar 29, 2024 at 12:49:47PM +0530, Krishna Kurapati wrote: > QDU1000 IDP [1] has a Type-c connector and supports USB 3.0. > However it relies on usb-conn-gpio driver to read the vbus and id > gpio's and provide role switch. However the driver currently has > only gpio-b-connector compatible present in ID table. Adding that > in DT would mean that the device supports Type-B connector and not > Type-c connector. > > Add gpio-usb-c-connector compatible to the driver to support such > cases. This is not a driver. Bindings commit messages should talk about the hardware they're supporting, not about drivers. > > [1]: https://lore.kernel.org/all/20240319091020.15137-3-quic_kbajaj@quicinc.com/ > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Documentation/devicetree/bindings/connector/usb-connector.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index fb216ce68bb3..2af27793c639 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -30,6 +30,9 @@ properties: > - const: samsung,usb-connector-11pin > - const: usb-b-connector > > + - items: > + - const: gpio-usb-c-connector This is over complicated, just needs to be "- const: gpio-usb-c-connector" Thanks, Conor. > + > reg: > maxItems: 1 > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml index fb216ce68bb3..2af27793c639 100644 --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml @@ -30,6 +30,9 @@ properties: - const: samsung,usb-connector-11pin - const: usb-b-connector + - items: + - const: gpio-usb-c-connector + reg: maxItems: 1
QDU1000 IDP [1] has a Type-c connector and supports USB 3.0. However it relies on usb-conn-gpio driver to read the vbus and id gpio's and provide role switch. However the driver currently has only gpio-b-connector compatible present in ID table. Adding that in DT would mean that the device supports Type-B connector and not Type-c connector. Add gpio-usb-c-connector compatible to the driver to support such cases. [1]: https://lore.kernel.org/all/20240319091020.15137-3-quic_kbajaj@quicinc.com/ Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- Documentation/devicetree/bindings/connector/usb-connector.yaml | 3 +++ 1 file changed, 3 insertions(+)