| Message ID | 20240329054657.1602450-1-dqfext@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RFC,v2,1/2] spi: dt-bindings: add Siflower Quad SPI controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29/03/2024 06:46, Qingfang Deng wrote: > From: Qingfang Deng <qingfang.deng@siflower.com.cn> > > Add YAML devicetree bindings for Siflower Quad SPI controller. Not much improved. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Allow people to actually review your code - give them some time, like 24h between postings. > > Signed-off-by: Qingfang Deng <qingfang.deng@siflower.com.cn> > --- > v2: fix dt_binding_check reported errors > > .../bindings/spi/siflower,qspi.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/siflower,qspi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/siflower,qspi.yaml b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > new file mode 100644 > index 000000000000..15ce25a2176a > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/siflower,qspi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Siflower Quad Serial Peripheral Interface (QSPI) > + > +maintainers: > + - Qingfang Deng <qingfang.deng@siflower.com.cn> > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + const: siflower,qspi > + My previous comments stay valid. Respond to them. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/siflower,qspi.yaml b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml new file mode 100644 index 000000000000..15ce25a2176a --- /dev/null +++ b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/siflower,qspi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Siflower Quad Serial Peripheral Interface (QSPI) + +maintainers: + - Qingfang Deng <qingfang.deng@siflower.com.cn> + +allOf: + - $ref: spi-controller.yaml# + +properties: + compatible: + const: siflower,qspi + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +required: + - compatible + - reg + - clocks + - '#address-cells' + - '#size-cells' + +unevaluatedProperties: false + +examples: + - | + spi@c200000 { + compatible = "siflower,qspi"; + reg = <0xc200000 0x1000>; + clocks = <&apb_clk>; + interrupts = <39>; + pinctrl-names = "default"; + pinctrl-0 = <&spi0_pins>; + #address-cells = <1>; + #size-cells = <0>; + };