| Message ID | 20240326220628.2392802-3-quic_amelende@quicinc.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add GPIO support for various PMICs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 26/03/2024 23:06, Anjelique Melendez wrote: > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to include compatible strings for PMIH0108 and PMD8028 PMICs. > > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Mar 26, 2024 at 5:07 PM Anjelique Melendez <quic_amelende@quicinc.com> wrote: > > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to include compatible strings for PMIH0108 and PMD8028 PMICs. You didn't test this with dtbs_check: 47 gpio@c000: gpio-line-names: ['AP_SUSPEND', '', '', '', '', '', '', '', '', '', '', ''] is too short 10 gpio@8800: gpio-line-names: ['FLASH_STROBE_1', 'AP_SUSPEND', 'PM8008_1_RST_N', '', '', '', 'PMIC_EDP_BL_EN', 'PMIC_EDP_BL_PWM', ''] is too short > > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > --- > .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > index 2b17d244f051..a786357ed1af 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > @@ -57,10 +57,12 @@ properties: > - qcom,pma8084-gpio > - qcom,pmc8180-gpio > - qcom,pmc8180c-gpio > + - qcom,pmd8028-gpio > - qcom,pmi632-gpio > - qcom,pmi8950-gpio > - qcom,pmi8994-gpio > - qcom,pmi8998-gpio > + - qcom,pmih0108-gpio > - qcom,pmk8350-gpio > - qcom,pmk8550-gpio > - qcom,pmm8155au-gpio > @@ -143,6 +145,7 @@ allOf: > - qcom,pm8005-gpio > - qcom,pm8450-gpio > - qcom,pm8916-gpio > + - qcom,pmd8028-gpio > - qcom,pmk8350-gpio > - qcom,pmr735a-gpio > - qcom,pmr735b-gpio > @@ -304,6 +307,21 @@ allOf: > minItems: 1 > maxItems: 7 > > + - if: > + properties: > + comptaible: It took me a bit to find, but you've got a typo here. The result is this "if" schema is always true unless you actually have an instance with the typo too. Please send a fix. > + contains: > + enum: > + - qcom,pmih0108-gpio > + then: > + properties: > + gpio-line-names: > + minItems: 18 > + maxItems: 18 > + gpio-reserved-ranges: > + minItems: 1 > + maxItems: 9
On 4/23/2024 10:02 AM, Rob Herring wrote: > It took me a bit to find, but you've got a typo here. The result is > this "if" schema is always true unless you actually have an instance > with the typo too. Please send a fix. Thanks for finding typo! Fix is here: https://lore.kernel.org/all/20240425185603.3295450-1-quic_amelende@quicinc.com/
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml index 2b17d244f051..a786357ed1af 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -57,10 +57,12 @@ properties: - qcom,pma8084-gpio - qcom,pmc8180-gpio - qcom,pmc8180c-gpio + - qcom,pmd8028-gpio - qcom,pmi632-gpio - qcom,pmi8950-gpio - qcom,pmi8994-gpio - qcom,pmi8998-gpio + - qcom,pmih0108-gpio - qcom,pmk8350-gpio - qcom,pmk8550-gpio - qcom,pmm8155au-gpio @@ -143,6 +145,7 @@ allOf: - qcom,pm8005-gpio - qcom,pm8450-gpio - qcom,pm8916-gpio + - qcom,pmd8028-gpio - qcom,pmk8350-gpio - qcom,pmr735a-gpio - qcom,pmr735b-gpio @@ -304,6 +307,21 @@ allOf: minItems: 1 maxItems: 7 + - if: + properties: + comptaible: + contains: + enum: + - qcom,pmih0108-gpio + then: + properties: + gpio-line-names: + minItems: 18 + maxItems: 18 + gpio-reserved-ranges: + minItems: 1 + maxItems: 9 + - if: properties: compatible: @@ -452,9 +470,11 @@ $defs: - gpio1-gpio22 for pm8994 - gpio1-gpio26 for pm8998 - gpio1-gpio22 for pma8084 + - gpio1-gpio4 for pmd8028 - gpio1-gpio8 for pmi632 - gpio1-gpio2 for pmi8950 - gpio1-gpio10 for pmi8994 + - gpio1-gpio18 for pmih0108 - gpio1-gpio4 for pmk8350 - gpio1-gpio6 for pmk8550 - gpio1-gpio10 for pmm8155au
Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation to include compatible strings for PMIH0108 and PMD8028 PMICs. Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> --- .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)