diff mbox series

[2/2] dt-bindings: qcom: Document samsung,fortuna

Message ID 20240326141222.200452-3-raymondhackley@protonmail.com
State Changes Requested
Headers show
Series arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Raymond Hackley March 26, 2024, 2:12 p.m. UTC
Document common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices below:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H  (msm8216-samsung-fortuna3g)
- SM-G530W  (msm8916-gprimeltecan)

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) March 27, 2024, 3:43 p.m. UTC | #1
On Tue, Mar 26, 2024 at 02:12:58PM +0000, Raymond Hackley wrote:
> Document common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices below:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H  (msm8216-samsung-fortuna3g)
> - SM-G530W  (msm8916-gprimeltecan)

Commit messages should answer "why?". Why do you need this?

Please test this binding change against your dts changes. I think you 
will find it fails.

> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 66beaac60e1d..2db776d78d22 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -204,6 +204,7 @@ properties:
>                - samsung,a5u-eur
>                - samsung,e5
>                - samsung,e7
> +              - samsung,fortuna
>                - samsung,fortuna3g
>                - samsung,gprimeltecan
>                - samsung,grandmax
> -- 
> 2.39.2
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 66beaac60e1d..2db776d78d22 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -204,6 +204,7 @@  properties:
               - samsung,a5u-eur
               - samsung,e5
               - samsung,e7
+              - samsung,fortuna
               - samsung,fortuna3g
               - samsung,gprimeltecan
               - samsung,grandmax