| Message ID | 20240326121735.11994-1-animeshagarwal28@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: ata: ahci-da850: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 36 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 3/26/24 21:17, Animesh Agarwal wrote: > Convert the ahci-da850 bindings to DT schema Missing a period at the end of the sentence. > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > --- > .../devicetree/bindings/ata/ahci-da850.txt | 18 ---------- > .../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++ > 2 files changed, 36 insertions(+), 18 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt > create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt > deleted file mode 100644 > index 5f8193417725..000000000000 > --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt > +++ /dev/null > @@ -1,18 +0,0 @@ > -Device tree binding for the TI DA850 AHCI SATA Controller > ---------------------------------------------------------- > - > -Required properties: > - - compatible: must be "ti,da850-ahci" > - - reg: physical base addresses and sizes of the two register regions > - used by the controller: the register map as defined by the > - AHCI 1.1 standard and the Power Down Control Register (PWRDN) > - for enabling/disabling the SATA clock receiver > - - interrupts: interrupt specifier (refer to the interrupt binding) > - > -Example: > - > - sata: sata@218000 { > - compatible = "ti,da850-ahci"; > - reg = <0x218000 0x2000>, <0x22c018 0x4>; > - interrupts = <67>; > - }; > diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > new file mode 100644 > index 000000000000..d54f58c12e78 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI DA850 AHCI SATA Controller > + > +maintainers: > + - Animesh Agarwal <animeshagarwal28@gmail.com> > + > +properties: > + compatible: > + const: ti,da850-ahci > + > + reg: > + minItems: 2 > + maxItems: 2 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + sata@218000 { > + compatible = "ti,da850-ahci"; > + reg = <0x218000 0x2000>, <0x22c018 0x4>; > + interrupts = <67>; > + };
On Tue, Mar 26, 2024 at 05:47:28PM +0530, Animesh Agarwal wrote: > - - compatible: must be "ti,da850-ahci" > - - reg: physical base addresses and sizes of the two register regions > - used by the controller: the register map as defined by the > - AHCI 1.1 standard and the Power Down Control Register (PWRDN) > - for enabling/disabling the SATA clock receiver > + reg: > + minItems: 2 > + maxItems: 2 Could you make this an items list with a pair of text descriptions please? The original text binding's text for each can be reused. Thanks, Conor.
Sorry for the typo, I'll add it. On Tue, Mar 26, 2024 at 5:55 PM Damien Le Moal <dlemoal@kernel.org> wrote: > > On 3/26/24 21:17, Animesh Agarwal wrote: > > Convert the ahci-da850 bindings to DT schema > > Missing a period at the end of the sentence. > > > > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > > --- > > .../devicetree/bindings/ata/ahci-da850.txt | 18 ---------- > > .../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++ > > 2 files changed, 36 insertions(+), 18 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt > > create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > > > > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt > > deleted file mode 100644 > > index 5f8193417725..000000000000 > > --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt > > +++ /dev/null > > @@ -1,18 +0,0 @@ > > -Device tree binding for the TI DA850 AHCI SATA Controller > > ---------------------------------------------------------- > > - > > -Required properties: > > - - compatible: must be "ti,da850-ahci" > > - - reg: physical base addresses and sizes of the two register regions > > - used by the controller: the register map as defined by the > > - AHCI 1.1 standard and the Power Down Control Register (PWRDN) > > - for enabling/disabling the SATA clock receiver > > - - interrupts: interrupt specifier (refer to the interrupt binding) > > - > > -Example: > > - > > - sata: sata@218000 { > > - compatible = "ti,da850-ahci"; > > - reg = <0x218000 0x2000>, <0x22c018 0x4>; > > - interrupts = <67>; > > - }; > > diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > > new file mode 100644 > > index 000000000000..d54f58c12e78 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > > @@ -0,0 +1,36 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI DA850 AHCI SATA Controller > > + > > +maintainers: > > + - Animesh Agarwal <animeshagarwal28@gmail.com> > > + > > +properties: > > + compatible: > > + const: ti,da850-ahci > > + > > + reg: > > + minItems: 2 > > + maxItems: 2 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + sata@218000 { > > + compatible = "ti,da850-ahci"; > > + reg = <0x218000 0x2000>, <0x22c018 0x4>; > > + interrupts = <67>; > > + }; > > -- > Damien Le Moal > Western Digital Research >
On Tue, Mar 26, 2024 at 11:44 PM Conor Dooley <conor@kernel.org> wrote: > Could you make this an items list with a pair of text descriptions > please? The original text binding's text for each can be reused. > Sure I'll do it. Thanks and regards Animesh
diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt deleted file mode 100644 index 5f8193417725..000000000000 --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt +++ /dev/null @@ -1,18 +0,0 @@ -Device tree binding for the TI DA850 AHCI SATA Controller ---------------------------------------------------------- - -Required properties: - - compatible: must be "ti,da850-ahci" - - reg: physical base addresses and sizes of the two register regions - used by the controller: the register map as defined by the - AHCI 1.1 standard and the Power Down Control Register (PWRDN) - for enabling/disabling the SATA clock receiver - - interrupts: interrupt specifier (refer to the interrupt binding) - -Example: - - sata: sata@218000 { - compatible = "ti,da850-ahci"; - reg = <0x218000 0x2000>, <0x22c018 0x4>; - interrupts = <67>; - }; diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml new file mode 100644 index 000000000000..d54f58c12e78 --- /dev/null +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DA850 AHCI SATA Controller + +maintainers: + - Animesh Agarwal <animeshagarwal28@gmail.com> + +properties: + compatible: + const: ti,da850-ahci + + reg: + minItems: 2 + maxItems: 2 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + sata@218000 { + compatible = "ti,da850-ahci"; + reg = <0x218000 0x2000>, <0x22c018 0x4>; + interrupts = <67>; + };
Convert the ahci-da850 bindings to DT schema Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> --- .../devicetree/bindings/ata/ahci-da850.txt | 18 ---------- .../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++ 2 files changed, 36 insertions(+), 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml