| Message ID | 20240326110506.78408-1-kanakshilledar@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3] dt-bindings: serial: actions,owl-uart: convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 50 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 26/03/2024 12:05, Kanak Shilledar wrote: > From: Kanak Shilledar <kanakshilledar111@protonmail.com> > > Convert the Actions Semi Owl UART to newer DT schema. > Created DT schema based on the .txt file which had > `compatible`, `reg`, `clocks` and `interrupts` as the That's not true. Old binding file did not have clocks. You did more than conversion and I asked you to describe changes which are different than pure conversion. Instead of sending another version the same day, can you please read carefully comments you receive? > required properties. This binding is used by Actions S500, S700 > and S900 SoC. S700 and S900 use the same UART compatible string. > Implemented a full node example for the UART, referenced S500 SoC > devicetree include. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Drop, you made MANY MORE changes than I asked, up to the point of making it broken. I don't understand. I asked three things. One you ignored, two implemented and then added more. > Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> > --- ... > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks That's surprising. Nothing in the changelog explains this. > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/actions,s500-cmu.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + uart0: serial@b0126000 { > + compatible = "actions,s500-uart", "actions,owl-uart"; > + reg = <0xb0126000 0x1000>; > + clocks = <&cmu CLK_UART0>; > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; NAK. Examples are not disabled. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/serial/actions,owl-uart.txt b/Documentation/devicetree/bindings/serial/actions,owl-uart.txt deleted file mode 100644 index aa873eada02d..000000000000 --- a/Documentation/devicetree/bindings/serial/actions,owl-uart.txt +++ /dev/null @@ -1,16 +0,0 @@ -Actions Semi Owl UART - -Required properties: -- compatible : "actions,s500-uart", "actions,owl-uart" for S500 - "actions,s900-uart", "actions,owl-uart" for S900 -- reg : Offset and length of the register set for the device. -- interrupts : Should contain UART interrupt. - - -Example: - - uart3: serial@b0126000 { - compatible = "actions,s500-uart", "actions,owl-uart"; - reg = <0xb0126000 0x1000>; - interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; - }; diff --git a/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml b/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml new file mode 100644 index 000000000000..b163060cdd33 --- /dev/null +++ b/Documentation/devicetree/bindings/serial/actions,owl-uart.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/serial/actions,owl-uart.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Actions Semi Owl UART + +maintainers: + - Kanak Shilledar <kanakshilledar111@protonmail.com> + +allOf: + - $ref: serial.yaml + +properties: + compatible: + items: + - enum: + - actions,s500-uart + - actions,s900-uart + - const: actions,owl-uart + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/actions,s500-cmu.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + uart0: serial@b0126000 { + compatible = "actions,s500-uart", "actions,owl-uart"; + reg = <0xb0126000 0x1000>; + clocks = <&cmu CLK_UART0>; + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + };