| Message ID | 20240325203245.31660-5-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: Add device tree source for the Au-Zone Maivin AI Vision Starter Kit | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/03/2024 21:32, Laurent Pinchart wrote: > The Maivin board is an AI vision starter kit sold by Au-Zone > Technologies, developed in collaboration with Toradex and Vision > Components. It is based on a Toradex Verdin i.MX8MP SoM. > > Add a corresponding compatible string. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 0027201e19f8..d892c4f9fda3 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1064,6 +1064,13 @@ properties: > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > - const: fsl,imx8mp > > + - description: Au-Zone Technologies i.MX8MP-based boards > + items: > + - const: au-zone,maivin-starter-kit # Au-Zone Maivin AI Vision Starter Kit > + - const: toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Module without Wi-Fi / BT > + - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module I think this should be part of existing "Toradex Boards with Verdin iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...". Best regards, Krzysztof
Hi Krzysztof, On Tue, Mar 26, 2024 at 08:11:34AM +0100, Krzysztof Kozlowski wrote: > On 25/03/2024 21:32, Laurent Pinchart wrote: > > The Maivin board is an AI vision starter kit sold by Au-Zone > > Technologies, developed in collaboration with Toradex and Vision > > Components. It is based on a Toradex Verdin i.MX8MP SoM. > > > > Add a corresponding compatible string. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 0027201e19f8..d892c4f9fda3 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -1064,6 +1064,13 @@ properties: > > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > > - const: fsl,imx8mp > > > > + - description: Au-Zone Technologies i.MX8MP-based boards > > + items: > > + - const: au-zone,maivin-starter-kit # Au-Zone Maivin AI Vision Starter Kit > > + - const: toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Module without Wi-Fi / BT > > + - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module > > I think this should be part of existing "Toradex Boards with Verdin > iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...". Is this what you have in mind ? diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index d892c4f9fda3..df5a04ab83a0 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1106,9 +1106,10 @@ properties: - const: polyhex,imx8mp-debix-som-a # Polyhex Debix SOM A - const: fsl,imx8mp - - description: Toradex Boards with Verdin iMX8M Plus Modules + - description: Boards using Toradex Verdin iMX8M Plus Modules items: - enum: + - au-zone,maivin-starter-kit # Au-Zone Maivin AI Vision Starter Kit - toradex,verdin-imx8mp-nonwifi-dahlia # Verdin iMX8M Plus Module on Dahlia - toradex,verdin-imx8mp-nonwifi-dev # Verdin iMX8M Plus Module on Verdin Development Board - toradex,verdin-imx8mp-nonwifi-mallow # Verdin iMX8M Plus Module on Mallow
On 27/03/2024 02:01, Laurent Pinchart wrote: > Hi Krzysztof, > > On Tue, Mar 26, 2024 at 08:11:34AM +0100, Krzysztof Kozlowski wrote: >> On 25/03/2024 21:32, Laurent Pinchart wrote: >>> The Maivin board is an AI vision starter kit sold by Au-Zone >>> Technologies, developed in collaboration with Toradex and Vision >>> Components. It is based on a Toradex Verdin i.MX8MP SoM. >>> >>> Add a corresponding compatible string. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> --- >>> Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 0027201e19f8..d892c4f9fda3 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1064,6 +1064,13 @@ properties: >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >>> - const: fsl,imx8mp >>> >>> + - description: Au-Zone Technologies i.MX8MP-based boards >>> + items: >>> + - const: au-zone,maivin-starter-kit # Au-Zone Maivin AI Vision Starter Kit >>> + - const: toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Module without Wi-Fi / BT >>> + - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module >> >> I think this should be part of existing "Toradex Boards with Verdin >> iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...". > > Is this what you have in mind ? > Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 0027201e19f8..d892c4f9fda3 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1064,6 +1064,13 @@ properties: - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules - const: fsl,imx8mp + - description: Au-Zone Technologies i.MX8MP-based boards + items: + - const: au-zone,maivin-starter-kit # Au-Zone Maivin AI Vision Starter Kit + - const: toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Module without Wi-Fi / BT + - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module + - const: fsl,imx8mp + - description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules items: - const: avnet,sm2s-imx8mp-14N0600E-ep1 # SM2S-IMX8PLUS-14N0600E on SM2-MB-EP1 Carrier Board
The Maivin board is an AI vision starter kit sold by Au-Zone Technologies, developed in collaboration with Toradex and Vision Components. It is based on a Toradex Verdin i.MX8MP SoM. Add a corresponding compatible string. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)