| Message ID | 20240323074326.1428-2-musashino.open@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: leds: add LED_FUNCTION_* mainly for router devices | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 23/03/2024 08:36, INAGAKI Hiroshi wrote: > Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network > connection. This is useful to distinguish those LEDs from LEDs that > indicates status of wired "wan" connection. > > example (on stock fw): > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, 23 Mar 2024 16:36:09 +0900, INAGAKI Hiroshi wrote: > Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network > connection. This is useful to distinguish those LEDs from LEDs that > indicates status of wired "wan" connection. > > example (on stock fw): > > IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low, > low, good) of mobile network connection via dongle connected to USB > port. > > - no signal: (none, turned off) > - too low: green:mobile & red:mobile (amber, blink) > - low: green:mobile & red:mobile (amber, turned on) > - good: green:mobile (turned on) > > Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> > Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> > --- > v1 -> v2 > > - move _MOBILE before _MTD > - improve the commit description > > include/dt-bindings/leds/common.h | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index ecea167930d9..6216ecdb06c7 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -90,6 +90,7 @@ #define LED_FUNCTION_INDICATOR "indicator" #define LED_FUNCTION_LAN "lan" #define LED_FUNCTION_MAIL "mail" +#define LED_FUNCTION_MOBILE "mobile" #define LED_FUNCTION_MTD "mtd" #define LED_FUNCTION_PANIC "panic" #define LED_FUNCTION_PROGRAMMING "programming"
Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network connection. This is useful to distinguish those LEDs from LEDs that indicates status of wired "wan" connection. example (on stock fw): IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low, low, good) of mobile network connection via dongle connected to USB port. - no signal: (none, turned off) - too low: green:mobile & red:mobile (amber, blink) - low: green:mobile & red:mobile (amber, turned on) - good: green:mobile (turned on) Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> --- v1 -> v2 - move _MOBILE before _MTD - improve the commit description include/dt-bindings/leds/common.h | 1 + 1 file changed, 1 insertion(+)