| Message ID | 20240309031609.270308-1-marex@denx.de |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/03/2024 04:15, Marek Vasut wrote: > CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon. > The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE . > This chip is present e.g. on muRata 1YN module. Extend the > binding with its DT compatible. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: "David S. Miller" <davem@davemloft.net> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote: > CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon. > The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE . > This chip is present e.g. on muRata 1YN module. Extend the > binding with its DT compatible. How come there's no fallback here? Looking at the binding patch there's no device-specific handling done, what's incompatibly different between this device and some of the other ones supported by the hci_bcm driver? > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-bluetooth@vger.kernel.org > Cc: netdev@vger.kernel.org > --- > Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml > index cc70b00c6ce57..670bff0078ed7 100644 > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml > @@ -27,6 +27,7 @@ properties: > - brcm,bcm4335a0 > - brcm,bcm4349-bt > - cypress,cyw4373a0-bt > + - infineon,cyw43439-bt > - infineon,cyw55572-bt > > shutdown-gpios: > -- > 2.43.0 >
On 3/17/24 4:03 PM, Conor Dooley wrote: > On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote: >> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon. >> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE . >> This chip is present e.g. on muRata 1YN module. Extend the >> binding with its DT compatible. > > How come there's no fallback here? Looking at the binding patch there's > no device-specific handling done, what's incompatibly different between > this device and some of the other ones supported by the hci_bcm driver? For posterity, should be addressed in V2.
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml index cc70b00c6ce57..670bff0078ed7 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml @@ -27,6 +27,7 @@ properties: - brcm,bcm4335a0 - brcm,bcm4349-bt - cypress,cyw4373a0-bt + - infineon,cyw43439-bt - infineon,cyw55572-bt shutdown-gpios:
CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon. The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE . This chip is present e.g. on muRata 1YN module. Extend the binding with its DT compatible. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: "David S. Miller" <davem@davemloft.net> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org --- Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 + 1 file changed, 1 insertion(+)