| Message ID | 20240306013414.18708-3-zhangyi@everest-semi.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: codecs: ES8326: change members of private structure | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Mar 06, 2024 at 09:34:14AM +0800, Zhang Yi wrote: > Removed mic1-src and mic2-src. and changed default value > of interrupt-clk We could do with a better changelog here. > - everest,mic1-src: > - $ref: /schemas/types.yaml#/definitions/uint8 > - description: > - the value of reg 2A when headset plugged. > - minimum: 0x00 > - maximum: 0x77 > - default: 0x22 > - > - everest,mic2-src: > - $ref: /schemas/types.yaml#/definitions/uint8 > - description: > - the value of reg 2A when headset unplugged. > - minimum: 0x00 > - maximum: 0x77 > - default: 0x44 This will make any DTs using the properties instantly buggy. I believe there's a way of marking properties as deprecated, you should use that instead. Or we could just leave the properties there and ignore them at runtime.
On Wed, Mar 06, 2024 at 12:36:50PM +0000, Mark Brown wrote: > On Wed, Mar 06, 2024 at 09:34:14AM +0800, Zhang Yi wrote: > > Removed mic1-src and mic2-src. and changed default value > > of interrupt-clk > > We could do with a better changelog here. > > > - everest,mic1-src: > > - $ref: /schemas/types.yaml#/definitions/uint8 > > - description: > > - the value of reg 2A when headset plugged. > > - minimum: 0x00 > > - maximum: 0x77 > > - default: 0x22 > > - > > - everest,mic2-src: > > - $ref: /schemas/types.yaml#/definitions/uint8 > > - description: > > - the value of reg 2A when headset unplugged. > > - minimum: 0x00 > > - maximum: 0x77 > > - default: 0x44 > > This will make any DTs using the properties instantly buggy. I believe > there's a way of marking properties as deprecated, you should use that > instead. Or we could just leave the properties there and ignore them at > runtime. 'deprecated: true' is the way. Rob
diff --git a/Documentation/devicetree/bindings/sound/everest,es8326.yaml b/Documentation/devicetree/bindings/sound/everest,es8326.yaml index 07781408e788..5c9ee6ba7980 100644 --- a/Documentation/devicetree/bindings/sound/everest,es8326.yaml +++ b/Documentation/devicetree/bindings/sound/everest,es8326.yaml @@ -37,22 +37,6 @@ properties: maximum: 0x0f default: 0x0f - everest,mic1-src: - $ref: /schemas/types.yaml#/definitions/uint8 - description: - the value of reg 2A when headset plugged. - minimum: 0x00 - maximum: 0x77 - default: 0x22 - - everest,mic2-src: - $ref: /schemas/types.yaml#/definitions/uint8 - description: - the value of reg 2A when headset unplugged. - minimum: 0x00 - maximum: 0x77 - default: 0x44 - everest,jack-detect-inverted: $ref: /schemas/types.yaml#/definitions/flag description: @@ -87,7 +71,7 @@ properties: 0 means the chip detect jack type again after button released. minimum: 0 maximum: 0x7f - default: 0x45 + default: 0x00 required: - compatible @@ -107,10 +91,8 @@ examples: clocks = <&clks 10>; clock-names = "mclk"; #sound-dai-cells = <0>; - everest,mic1-src = [22]; - everest,mic2-src = [44]; everest,jack-pol = [0e]; everest,interrupt-src = [08]; - everest,interrupt-clk = [45]; + everest,interrupt-clk = [00]; }; };
Removed mic1-src and mic2-src. and changed default value of interrupt-clk Signed-off-by: Zhang Yi <zhangyi@everest-semi.com> --- .../bindings/sound/everest,es8326.yaml | 22 ++----------------- 1 file changed, 2 insertions(+), 20 deletions(-)