| Message ID | 20240305133137.125020-1-jeremie.dautheribes@bootlin.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] dt-bindings: net: dp83822: change ti,rmii-mode description | expand |
Sorry I forgot to include the "net-next" entry in the subject, I'm sending this patch again with the correct subject. On 05/03/2024 14:31, Jérémie Dautheribes wrote: > Drop reference to the 25MHz clock as it has nothing to do with connecting > the PHY and the MAC. > Add info about the reference clock direction between the PHY and the MAC > as it depends on the selected rmii mode. > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com> > --- > This patch follows on from my previous patch series [1] which has already been > merged into the net-next tree and which added the "ti,rmii-mode" property. > As suggested by Andrew Lunn, this patch updates the description of this > property to make it more consistent with the master/slave relationship it > conveys. > > [1] https://lore.kernel.org/all/20240222103117.526955-1-jeremie.dautheribes@bootlin.com/ > > Documentation/devicetree/bindings/net/ti,dp83822.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml > index 8f23254c0458..784866ea392b 100644 > --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml > +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml > @@ -84,10 +84,10 @@ properties: > description: | > If present, select the RMII operation mode. Two modes are > available: > - - RMII master, where the PHY operates from a 25MHz clock reference, > - provided by a crystal or a CMOS-level oscillator > - - RMII slave, where the PHY operates from a 50MHz clock reference, > - provided by a CMOS-level oscillator > + - RMII master, where the PHY outputs a 50MHz reference clock which can > + be connected to the MAC. > + - RMII slave, where the PHY expects a 50MHz reference clock input > + shared with the MAC. > The RMII operation mode can also be configured by its straps. > If the strap pin is not set correctly or not set at all, then this can be > used to configure it.
diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml index 8f23254c0458..784866ea392b 100644 --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml @@ -84,10 +84,10 @@ properties: description: | If present, select the RMII operation mode. Two modes are available: - - RMII master, where the PHY operates from a 25MHz clock reference, - provided by a crystal or a CMOS-level oscillator - - RMII slave, where the PHY operates from a 50MHz clock reference, - provided by a CMOS-level oscillator + - RMII master, where the PHY outputs a 50MHz reference clock which can + be connected to the MAC. + - RMII slave, where the PHY expects a 50MHz reference clock input + shared with the MAC. The RMII operation mode can also be configured by its straps. If the strap pin is not set correctly or not set at all, then this can be used to configure it.
Drop reference to the 25MHz clock as it has nothing to do with connecting the PHY and the MAC. Add info about the reference clock direction between the PHY and the MAC as it depends on the selected rmii mode. Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com> --- This patch follows on from my previous patch series [1] which has already been merged into the net-next tree and which added the "ti,rmii-mode" property. As suggested by Andrew Lunn, this patch updates the description of this property to make it more consistent with the master/slave relationship it conveys. [1] https://lore.kernel.org/all/20240222103117.526955-1-jeremie.dautheribes@bootlin.com/ Documentation/devicetree/bindings/net/ti,dp83822.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)