| Message ID | 20240224213240.1854709-7-sre@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | UNI-T UTi260B support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 20 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, Feb 24, 2024 at 6:33 PM Sebastian Reichel <sre@kernel.org> wrote: > > i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, > but has only very lightweight DISPLAY power domain. Its DISPLAY > power domain is not supported by the binding / Linux kernel at > the moment. Since the current setup is working, let's remove the > power-domain from being required for that platform to fix the warning > printed by CHECK_DTBS=y. Thanks, this also fixes the following imx8mq warnings: imx8mq-evk.dtb: lcd-controller@30320000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml# Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Sat, 24 Feb 2024 22:29:38 +0100, Sebastian Reichel wrote: > i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, > but has only very lightweight DISPLAY power domain. Its DISPLAY > power domain is not supported by the binding / Linux kernel at > the moment. Since the current setup is working, let's remove the > power-domain from being required for that platform to fix the warning > printed by CHECK_DTBS=y. > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sebastian Reichel <sre@kernel.org> > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 1c2be8d6f633..0681fc49aa1b 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -120,13 +120,19 @@ allOf: maxItems: 1 clock-names: maxItems: 1 + - if: + properties: + compatible: + const: fsl,imx6sx-lcdif + then: + required: + - power-domains - if: properties: compatible: contains: enum: - fsl,imx6sl-lcdif - - fsl,imx6sx-lcdif - fsl,imx8mm-lcdif - fsl,imx8mn-lcdif - fsl,imx8mp-lcdif
i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove the power-domain from being required for that platform to fix the warning printed by CHECK_DTBS=y. Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Sebastian Reichel <sre@kernel.org> --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)