| Message ID | 20240129142121.102450-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: net: qcom,ipa: do not override firmware-name $ref | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Jan 29, 2024 at 03:21:21PM +0100, Krzysztof Kozlowski wrote: > dtschema package defines firmware-name as string-array, so individual > bindings should not make it a string but instead just narrow the number > of expected firmware file names. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On 1/29/24 8:21 AM, Krzysztof Kozlowski wrote: > dtschema package defines firmware-name as string-array, so individual > bindings should not make it a string but instead just narrow the number > of expected firmware file names. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Fine with me. Acked-by: Alex Elder <elder@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index c30218684cfe..53cae71d9957 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -159,7 +159,7 @@ properties: > when the AP (not the modem) performs early initialization. > > firmware-name: > - $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > description: > If present, name (or relative path) of the file within the > firmware search path containing the firmware image used when
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Mon, 29 Jan 2024 15:21:21 +0100 you wrote: > dtschema package defines firmware-name as string-array, so individual > bindings should not make it a string but instead just narrow the number > of expected firmware file names. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - dt-bindings: net: qcom,ipa: do not override firmware-name $ref https://git.kernel.org/netdev/net-next/c/b2005bb756e1 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index c30218684cfe..53cae71d9957 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -159,7 +159,7 @@ properties: when the AP (not the modem) performs early initialization. firmware-name: - $ref: /schemas/types.yaml#/definitions/string + maxItems: 1 description: If present, name (or relative path) of the file within the firmware search path containing the firmware image used when
dtschema package defines firmware-name as string-array, so individual bindings should not make it a string but instead just narrow the number of expected firmware file names. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)