| Message ID | 20240123083517.21091-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: memory-controllers: narrow regex for unit address to hex numbers | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 23/01/2024 08:35, Krzysztof Kozlowski wrote: > Regular expression used to match the unit address part should not allow > non-hex numbers. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml > index f54e553e6c0e..71896cb10692 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml > @@ -145,7 +145,7 @@ patternProperties: > "^emc-table@[0-9]+$": > $ref: "#/$defs/emc-table" > > - "^emc-tables@[a-z0-9-]+$": > + "^emc-tables@[a-f0-9-]+$": > type: object > properties: > reg: Thanks! We could add the fixes tag ... Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema Otherwise ... Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Jon
On 23/01/2024 10:20, Jon Hunter wrote: > > On 23/01/2024 08:35, Krzysztof Kozlowski wrote: >> Regular expression used to match the unit address part should not allow >> non-hex numbers. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml >> index f54e553e6c0e..71896cb10692 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml >> @@ -145,7 +145,7 @@ patternProperties: >> "^emc-table@[0-9]+$": >> $ref: "#/$defs/emc-table" >> >> - "^emc-tables@[a-z0-9-]+$": >> + "^emc-tables@[a-f0-9-]+$": >> type: object >> properties: >> reg: > > > Thanks! We could add the fixes tag ... > > Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema There is no bug here, really. At least no bug with impact, because dtc won't allow DTS with non-hex numbers. Best regards, Krzysztof
On Tue, 23 Jan 2024 09:35:17 +0100, Krzysztof Kozlowski wrote: > Regular expression used to match the unit address part should not allow > non-hex numbers. > > Applied, thanks! [1/1] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers https://git.kernel.org/krzk/linux-mem-ctrl/c/2f542c937c48c2bd5a8ddf180b417fbe7152559f Best regards,
diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml index f54e553e6c0e..71896cb10692 100644 --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml @@ -145,7 +145,7 @@ patternProperties: "^emc-table@[0-9]+$": $ref: "#/$defs/emc-table" - "^emc-tables@[a-z0-9-]+$": + "^emc-tables@[a-f0-9-]+$": type: object properties: reg:
Regular expression used to match the unit address part should not allow non-hex numbers. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)