[v7,1/9] of: property: fix typo in io-channels

From: Nuno Sa <nuno.sa@analog.com>

The property is io-channels and not io-channel. This was effectively
preventing the devlink creation.

Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels")
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
 drivers/of/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
<devnull+nuno.sa.analog.com@kernel.org> wrote:
>
> From: Nuno Sa <nuno.sa@analog.com>
>
> The property is io-channels and not io-channel. This was effectively
> preventing the devlink creation.

Thank you!

Reviewed-by: Saravana Kannan <saravanak@google.com>

>
> Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels")
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> ---
>  drivers/of/property.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 641a40cf5cf3..bbf0dee2fb9c 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1244,7 +1244,7 @@ DEFINE_SIMPLE_PROP(clocks, "clocks", "#clock-cells")
>  DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
>  DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
>  DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
> -DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
> +DEFINE_SIMPLE_PROP(io_channels, "io-channels", "#io-channel-cells")
>  DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
>  DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
>  DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells")
>
> --
> 2.43.0
>

On Wed, 24 Jan 2024 19:14:35 -0800
Saravana Kannan <saravanak@google.com> wrote:

> On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> <devnull+nuno.sa.analog.com@kernel.org> wrote:
> >
> > From: Nuno Sa <nuno.sa@analog.com>
> >
> > The property is io-channels and not io-channel. This was effectively
> > preventing the devlink creation.  

I'm a bit lost on the devlink side of things. Is this something with
effects on existing drivers before this patch set, or is it only causing
real problems with the changes in here?

i.e. Should we mark it for stable and rush it in as a fix, or can it wait
for the rest of the set?

Jonathan

> 
> Thank you!
> 
> Reviewed-by: Saravana Kannan <saravanak@google.com>

> 
> >
> > Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels")
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
> >  drivers/of/property.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/property.c b/drivers/of/property.c
> > index 641a40cf5cf3..bbf0dee2fb9c 100644
> > --- a/drivers/of/property.c
> > +++ b/drivers/of/property.c
> > @@ -1244,7 +1244,7 @@ DEFINE_SIMPLE_PROP(clocks, "clocks", "#clock-cells")
> >  DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
> >  DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
> >  DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
> > -DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
> > +DEFINE_SIMPLE_PROP(io_channels, "io-channels", "#io-channel-cells")
> >  DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
> >  DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
> >  DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells")
> >
> > --
> > 2.43.0
> >

On Sat, 27 Jan 2024 15:07:26 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 24 Jan 2024 19:14:35 -0800
> Saravana Kannan <saravanak@google.com> wrote:
> 
> > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > <devnull+nuno.sa.analog.com@kernel.org> wrote:  
> > >
> > > From: Nuno Sa <nuno.sa@analog.com>
> > >
> > > The property is io-channels and not io-channel. This was effectively
> > > preventing the devlink creation.    
> 
> I'm a bit lost on the devlink side of things. Is this something with
> effects on existing drivers before this patch set, or is it only causing
> real problems with the changes in here?
> 
> i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> for the rest of the set?
> 
I'm also fine with this going via DT tree if that makes more sense.
If that happens.

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> Jonathan
> 
> > 
> > Thank you!
> > 
> > Reviewed-by: Saravana Kannan <saravanak@google.com>  
> 
> >   
> > >
> > > Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels")
> > > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > > ---
> > >  drivers/of/property.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/property.c b/drivers/of/property.c
> > > index 641a40cf5cf3..bbf0dee2fb9c 100644
> > > --- a/drivers/of/property.c
> > > +++ b/drivers/of/property.c
> > > @@ -1244,7 +1244,7 @@ DEFINE_SIMPLE_PROP(clocks, "clocks", "#clock-cells")
> > >  DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
> > >  DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
> > >  DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
> > > -DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
> > > +DEFINE_SIMPLE_PROP(io_channels, "io-channels", "#io-channel-cells")
> > >  DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
> > >  DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
> > >  DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells")
> > >
> > > --
> > > 2.43.0
> > >    
> 
>

On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote:
> On Wed, 24 Jan 2024 19:14:35 -0800
> Saravana Kannan <saravanak@google.com> wrote:
> 
> > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > > 
> > > From: Nuno Sa <nuno.sa@analog.com>
> > > 
> > > The property is io-channels and not io-channel. This was effectively
> > > preventing the devlink creation.  
> 
> I'm a bit lost on the devlink side of things. Is this something with
> effects on existing drivers before this patch set, or is it only causing
> real problems with the changes in here?
> 
> i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> for the rest of the set?
> 

I guess you already figured this out? Anyways, this is a real fix that was
affecting any consumer using io-channels (so nothing to do with the current
series). Since the there was a typo, no fw_links were being created.

I stated in the cover why I included this. Just to make the addition of io-
backends later on easier. But if Rob prefers (or you), I can just send this
standalone patch to the devicetree list.

- Nuno Sá
> 
>

On Mon, Jan 29, 2024 at 12:15 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote:
> > On Wed, 24 Jan 2024 19:14:35 -0800
> > Saravana Kannan <saravanak@google.com> wrote:
> >
> > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > > <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > > >
> > > > From: Nuno Sa <nuno.sa@analog.com>
> > > >
> > > > The property is io-channels and not io-channel. This was effectively
> > > > preventing the devlink creation.
> >
> > I'm a bit lost on the devlink side of things. Is this something with
> > effects on existing drivers before this patch set, or is it only causing
> > real problems with the changes in here?
> >
> > i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> > for the rest of the set?
> >
>
> I guess you already figured this out? Anyways, this is a real fix that was
> affecting any consumer using io-channels (so nothing to do with the current
> series). Since the there was a typo, no fw_links were being created.
>
> I stated in the cover why I included this. Just to make the addition of io-
> backends later on easier. But if Rob prefers (or you), I can just send this
> standalone patch to the devicetree list.

I think you should send this to Rob directly as a DT fix. I already
gave you a Reviewed-by too. So it should land quickly.

This is a real bug that we want to fix as soon as we can. And your
series might take a bit longer to land.

-Saravana

On Mon, 2024-01-29 at 14:33 -0800, Saravana Kannan wrote:
> On Mon, Jan 29, 2024 at 12:15 AM Nuno Sá <noname.nuno@gmail.com> wrote:
> > 
> > On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote:
> > > On Wed, 24 Jan 2024 19:14:35 -0800
> > > Saravana Kannan <saravanak@google.com> wrote:
> > > 
> > > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > > > <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > > > > 
> > > > > From: Nuno Sa <nuno.sa@analog.com>
> > > > > 
> > > > > The property is io-channels and not io-channel. This was effectively
> > > > > preventing the devlink creation.
> > > 
> > > I'm a bit lost on the devlink side of things. Is this something with
> > > effects on existing drivers before this patch set, or is it only causing
> > > real problems with the changes in here?
> > > 
> > > i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> > > for the rest of the set?
> > > 
> > 
> > I guess you already figured this out? Anyways, this is a real fix that was
> > affecting any consumer using io-channels (so nothing to do with the current
> > series). Since the there was a typo, no fw_links were being created.
> > 
> > I stated in the cover why I included this. Just to make the addition of io-
> > backends later on easier. But if Rob prefers (or you), I can just send this
> > standalone patch to the devicetree list.
> 
> I think you should send this to Rob directly as a DT fix. I already
> gave you a Reviewed-by too. So it should land quickly.
> 
> This is a real bug that we want to fix as soon as we can. And your
> series might take a bit longer to land.
> 
> -Saravana

Alright... will do that

- Nuno Sá

On Tue, Jan 30, 2024 at 11:32:00AM +0100, Nuno Sá wrote:
> On Mon, 2024-01-29 at 14:33 -0800, Saravana Kannan wrote:
> > On Mon, Jan 29, 2024 at 12:15 AM Nuno Sá <noname.nuno@gmail.com> wrote:
> > > 
> > > On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote:
> > > > On Wed, 24 Jan 2024 19:14:35 -0800
> > > > Saravana Kannan <saravanak@google.com> wrote:
> > > > 
> > > > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay
> > > > > <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > > > > > 
> > > > > > From: Nuno Sa <nuno.sa@analog.com>
> > > > > > 
> > > > > > The property is io-channels and not io-channel. This was effectively
> > > > > > preventing the devlink creation.
> > > > 
> > > > I'm a bit lost on the devlink side of things. Is this something with
> > > > effects on existing drivers before this patch set, or is it only causing
> > > > real problems with the changes in here?
> > > > 
> > > > i.e. Should we mark it for stable and rush it in as a fix, or can it wait
> > > > for the rest of the set?
> > > > 
> > > 
> > > I guess you already figured this out? Anyways, this is a real fix that was
> > > affecting any consumer using io-channels (so nothing to do with the current
> > > series). Since the there was a typo, no fw_links were being created.
> > > 
> > > I stated in the cover why I included this. Just to make the addition of io-
> > > backends later on easier. But if Rob prefers (or you), I can just send this
> > > standalone patch to the devicetree list.
> > 
> > I think you should send this to Rob directly as a DT fix. I already
> > gave you a Reviewed-by too. So it should land quickly.
> > 
> > This is a real bug that we want to fix as soon as we can. And your
> > series might take a bit longer to land.
> > 
> > -Saravana
> 
> Alright... will do that

No need to resend. I'll apply this one.

Rob

On Tue, 23 Jan 2024 16:14:22 +0100, Nuno Sa wrote:
> The property is io-channels and not io-channel. This was effectively
> preventing the devlink creation.
> 
> Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels")
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> ---
>  drivers/of/property.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!

On Tue, 2024-01-30 at 14:54 -0600, Rob Herring wrote:
> 
> On Tue, 23 Jan 2024 16:14:22 +0100, Nuno Sa wrote:
> > The property is io-channels and not io-channel. This was effectively
> > preventing the devlink creation.
> > 
> > Fixes: 8e12257dead7 ("of: property: Add device link support for iommus,
> > mboxes and io-channels")
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
> >  drivers/of/property.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Applied, thanks!
> 

Thanks Rob!

- Nuno Sá