diff mbox series

dt-bindings: can: fsl,flexcan: add i.MX95 compatible string

Message ID 20240122091738.2078746-1-peng.fan@oss.nxp.com
State Accepted
Headers show
Series dt-bindings: can: fsl,flexcan: add i.MX95 compatible string | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Peng Fan (OSS) Jan. 22, 2024, 9:17 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Add i.MX95 flexcan which is compatible i.MX93 flexcan

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Conor Dooley Jan. 22, 2024, 9:30 a.m. UTC | #1 
On Mon, Jan 22, 2024 at 05:17:38PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
>                - fsl,imx6ul-flexcan
>                - fsl,imx6sx-flexcan
>            - const: fsl,imx6q-flexcan
> +      - items:
> +          - const: fsl,imx95-flexcan
> +          - const: fsl,imx93-flexcan
>        - items:
>            - enum:
>                - fsl,ls1028ar1-flexcan
> -- 
> 2.37.1
>
Marc Kleine-Budde Jan. 22, 2024, 10:26 a.m. UTC | #2 
On 22.01.2024 17:17:38, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

regards,
Marc

> ---
>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
>                - fsl,imx6ul-flexcan
>                - fsl,imx6sx-flexcan
>            - const: fsl,imx6q-flexcan
> +      - items:
> +          - const: fsl,imx95-flexcan
> +          - const: fsl,imx93-flexcan
>        - items:
>            - enum:
>                - fsl,ls1028ar1-flexcan
> -- 
> 2.37.1
> 
>
Jakub Kicinski Jan. 22, 2024, 8:56 p.m. UTC | #3 
On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>  
> 
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Hm, you don't apply CAN DTB patches?
Peng Fan Jan. 23, 2024, 7 a.m. UTC | #4 
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
> 
> On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >
> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> Hm, you don't apply CAN DTB patches?

Nope. I am preparing dt-binding first, then post the i.MX95 SoC
dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
single patch only for CAN node.

Thanks,
Peng.
Rob Herring (Arm) Jan. 31, 2024, 2:57 p.m. UTC | #5 
On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> > 
> > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > >
> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > 
> > Hm, you don't apply CAN DTB patches?
> 
> Nope. I am preparing dt-binding first, then post the i.MX95 SoC
> dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
> single patch only for CAN node.

The question was why isn't Marc, the CAN maintainer, applying this. I 
have the same question.

Rob
Peng Fan Jan. 31, 2024, 11:22 p.m. UTC | #6 
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
> 
> On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > compatible string
> > >
> > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > >
> > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > >
> > > Hm, you don't apply CAN DTB patches?
> >
> > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > for CAN node.
> 
> The question was why isn't Marc, the CAN maintainer, applying this. I have
> the same question.

That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
patch file, it will be in a separate patchset with some i.MX95 patches.

Thanks,
Peng.

> 
> Rob
Conor Dooley Feb. 1, 2024, 6:40 p.m. UTC | #7 
On Wed, Jan 31, 2024 at 11:22:49PM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> > 
> > On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > > compatible string
> > > >
> > > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > > >
> > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > >
> > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > > >
> > > > Hm, you don't apply CAN DTB patches?
> > >
> > > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > > for CAN node.
> > 
> > The question was why isn't Marc, the CAN maintainer, applying this. I have
> > the same question.
> 
> That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
> patch file, it will be in a separate patchset with some i.MX95 patches.

I am confused. This patch (for the binding) needs to be applied
regardless of what you are doing with your soc dtsi file.
Rob Herring (Arm) Feb. 12, 2024, 1:56 p.m. UTC | #8 
On Mon, 22 Jan 2024 17:17:38 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

It seems this isn't getting applied to CAN tree, so I applied it.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
index 4162469c3c08..f197d9b516bb 100644
--- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
+++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
@@ -38,6 +38,9 @@  properties:
               - fsl,imx6ul-flexcan
               - fsl,imx6sx-flexcan
           - const: fsl,imx6q-flexcan
+      - items:
+          - const: fsl,imx95-flexcan
+          - const: fsl,imx93-flexcan
       - items:
           - enum:
               - fsl,ls1028ar1-flexcan