| Message ID | 20231228131617.3411561-4-liujianfeng1994@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add hantro g1 video decoder support for RK3588 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 28/12/2023 14:16, Jianfeng Liu wrote: > Add compatible for rk3588 Hantro G1 vpu decoder. > > Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index c57e1f488..ba41446f6 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -25,6 +25,7 @@ properties: > - rockchip,px30-vpu > - rockchip,rk3568-vpu > - rockchip,rk3588-av1-vpu > + - rockchip,rk3588-vpu Your driver suggests it is compatible with 3568-vpu. Also, nothing in commit msg explains me differences against existing av1-vpu. Best regards, Krzysztof
Hi Krzysztof, Sat, 30 Dec 2023 17:06:48 +0100, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >Your driver suggests it is compatible with 3568-vpu. > >Also, nothing in commit msg explains me differences against existing >av1-vpu. Yes, this vpu is exactly the same as the one on rk3568, so we can make rockchip,rk3588-vpu compatible with rockchip,rk3568-vpu, just like what we have done on rk3188/rk3066 and rk3228/rk3399. I will update it in v3 patch. Best regards, Jianfeng
diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml index c57e1f488..ba41446f6 100644 --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml @@ -25,6 +25,7 @@ properties: - rockchip,px30-vpu - rockchip,rk3568-vpu - rockchip,rk3588-av1-vpu + - rockchip,rk3588-vpu - items: - const: rockchip,rk3188-vpu - const: rockchip,rk3066-vpu
Add compatible for rk3588 Hantro G1 vpu decoder. Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> --- Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 1 + 1 file changed, 1 insertion(+)