| Message ID | 20231226-support-clearfog-gtr-l8-sfp-v3-2-fd1ac2d6bf2e@solid-run.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 26 Dec 2023 19:11:33 +0100, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 > boards. > > Despite similar name these two boards are designed differently from the > armada 388 clearfog base and pro, they only share a name and general use > case. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml:36:14: [warning] wrong indentation: expected 14 but found 13 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231226-support-clearfog-gtr-l8-sfp-v3-2-fd1ac2d6bf2e@solid-run.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 26/12/2023 19:11, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 > boards. > > Despite similar name these two boards are designed differently from the > armada 388 clearfog base and pro, they only share a name and general use > case. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > index 5af222e6db18..5bc69c4fe34d 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -30,4 +30,12 @@ properties: > - const: marvell,armada385 > - const: marvell,armada380 > > + - description: SolidRun Armada 385 based single-board computers > + items: > + - enum: > + - solidrun,clearfog-gtr-l8 When I pointed out in your previous versions that you do not test patches, I did it in hope to encourage testing patches... Standard boiler plate: It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml index 5af222e6db18..5bc69c4fe34d 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml @@ -30,4 +30,12 @@ properties: - const: marvell,armada385 - const: marvell,armada380 + - description: SolidRun Armada 385 based single-board computers + items: + - enum: + - solidrun,clearfog-gtr-l8 + - solidrun,clearfog-gtr-s4 + - const: marvell,armada385 + - const: marvell,armada380 + additionalProperties: true
Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 boards. Despite similar name these two boards are designed differently from the armada 388 clearfog base and pro, they only share a name and general use case. Signed-off-by: Josua Mayer <josua@solid-run.com> --- Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)