| Message ID | 20231225053932.1138-1-shenghao-ding@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/12/2023 06:39, Shenghao Ding wrote: > Move tas2563 from tas2562.yaml to tas2781.yaml, because tas2563 only work > in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for > tas2563, it has been moved to tas2781 driver. As to the hardware part, > such as register setting and DSP firmware, all these are stored in the > binary firmware. What tas2781 drivder dooes is to parse the firmware and > download them to the tas2781 or tas2563, then power on tas2781 or tas2563. > So, tas2781 driver can be resued as tas2563 driver。 Only attention will > be paid to downloading corresponding firmware. > > Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> > > --- > Change in v3: > - remove tas2563, which will be move to tas2781 driver > - Add more comments on why move tas2563 to tas2781 driver > - provide rationale in terms of bindings and hardware, not in terms of driver. > Or at least not only. How did you implement my comment about squashing? If you decided not to implement it, why not dropping a note? Best regards, Krzysztof
On Mon, Dec 25, 2023 at 01:39:28PM +0800, Shenghao Ding wrote: > Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only > work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode > for tas2563, it has been moved to tas2781 driver. As to the hardware part, > such as register setting and DSP firmware, all these are stored in the > binary firmware. What tas2781 drivder dooes is to parse the firmware and > download them to the tas2781 or tas2563, then power on tas2781 or tas2563. > So, tas2781 driver can be resued as tas2563 driver。 Only attention will > be paid to downloading corresponding firmware. I dunno if you got my emails, but my comments were completely ignored. You can't do this patch as after it the current users may have a regression.
On Mon, Dec 25, 2023 at 01:39:30PM +0800, Shenghao Ding wrote: > Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only > work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode > for tas2563, it has been moved to tas2781 driver. As to the hardware part, > such as register setting and DSP firmware, all these are stored in the > binary firmware. What tas2781 drivder dooes is to parse the firmware and > download them to the tas2781 or tas2563, then power on tas2781 or tas2563. > So, tas2781 driver can be resued as tas2563 driver. Only attention will be > paid to downloading corresponding firmware. > -// The TAS2781 driver implements a flexible and configurable > +// The TAS2781/TAS2563 driver implements a flexible and configurable > -// TAS2781 chips. > +// TAS2781/TAS2563 chips. > static const struct i2c_device_id tasdevice_id[] = { > { "tas2781", TAS2781 }, > + { "tas2563", TAS2563 }, > {} > }; > static const struct of_device_id tasdevice_of_match[] = { > { .compatible = "ti,tas2781" }, > + { .compatible = "ti,tas2563" }, > {}, > }; In all cases make the lists ordered by a chip model.
diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml index f01c0dde0cf7..d28c102c0ce7 100644 --- a/Documentation/devicetree/bindings/sound/tas2562.yaml +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml @@ -18,7 +18,6 @@ description: | Specifications about the audio amplifier can be found at: https://www.ti.com/lit/gpn/tas2562 - https://www.ti.com/lit/gpn/tas2563 https://www.ti.com/lit/gpn/tas2564 https://www.ti.com/lit/gpn/tas2110 @@ -29,7 +28,6 @@ properties: compatible: enum: - ti,tas2562 - - ti,tas2563 - ti,tas2564 - ti,tas2110
Move tas2563 from tas2562.yaml to tas2781.yaml, because tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder dooes is to parse the firmware and download them to the tas2781 or tas2563, then power on tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。 Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- Change in v3: - remove tas2563, which will be move to tas2781 driver - Add more comments on why move tas2563 to tas2781 driver - provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. --- Documentation/devicetree/bindings/sound/tas2562.yaml | 2 -- 1 file changed, 2 deletions(-)