| Message ID | 20231209105926.3965-1-579lpy@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | iio: humidity: Add driver for ti HDC302x humidity sensors | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/12/2023 11:59, Li peiyu wrote: > Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and > temperature sensors. > > Signed-off-by: Li peiyu <579lpy@gmail.com> > --- > .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > > diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > new file mode 100644 > index 000000000000..f04b09fdca5e > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors > + > +maintainers: > + - Li peiyu <579lpy@gmail.com> > + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > + > +description: > + https://www.ti.com/lit/ds/symlink/hdc3020.pdf > + > + The HDC302x is an integrated capacitive based relative humidity (RH) > + and temperature sensor. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - ti,hdc3021 > + - ti,hdc3022 > + - const: ti,hdc3020 > + - items: > + - const: ti,hdc3020 Three of my comments were ignored. Also Conor's tag. This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On Sat, Dec 09, 2023 at 12:49:45PM +0100, Krzysztof Kozlowski wrote: > On 09/12/2023 11:59, Li peiyu wrote: > > Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and > > temperature sensors. > > > > Signed-off-by: Li peiyu <579lpy@gmail.com> > > --- > > .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > > new file mode 100644 > > index 000000000000..f04b09fdca5e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors > > + > > +maintainers: > > + - Li peiyu <579lpy@gmail.com> > > + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > > + > > +description: > > + https://www.ti.com/lit/ds/symlink/hdc3020.pdf > > + > > + The HDC302x is an integrated capacitive based relative humidity (RH) > > + and temperature sensor. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - ti,hdc3021 > > + - ti,hdc3022 > > + - const: ti,hdc3020 > > + - items: > > + - const: ti,hdc3020 > > > Three of my comments were ignored. > Also Conor's tag. tbh, that's not a problem for me given there were mistakes that I overlooked and they persisted into this version. > > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml new file mode 100644 index 000000000000..f04b09fdca5e --- /dev/null +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors + +maintainers: + - Li peiyu <579lpy@gmail.com> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> + +description: + https://www.ti.com/lit/ds/symlink/hdc3020.pdf + + The HDC302x is an integrated capacitive based relative humidity (RH) + and temperature sensor. + +properties: + compatible: + oneOf: + - items: + - enum: + - ti,hdc3021 + - ti,hdc3022 + - const: ti,hdc3020 + - items: + - const: ti,hdc3020 + + interrupts: + maxItems: 1 + + vdd-supply: true + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + humidity-sensor@47 { + compatible = "ti,hdc3021", "ti,hdc3020"; + reg = <0x47>; + vdd-supply = <&vcc_3v3>; + }; + };
Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and temperature sensors. Signed-off-by: Li peiyu <579lpy@gmail.com> --- .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml