| Message ID | 20231207080235.652719-1-andyshrk@163.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add VOP2 support on rk3588 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: > From: Andy Yan <andy.yan@rock-chips.com> > > Add a Rockchip RK3588 compatible > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> In the next iteration, please split this out into a separate patch and send it to the iommu+dt maintainers. Supporting the iommus on rk3588 can be realized separately and the patch needs to go through a separate tree anyway. Thanks Heiko
On 07/12/2023 09:02, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> > > Add a Rockchip RK3588 compatible > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Heiko: On 12/9/23 00:29, Heiko Stübner wrote: > Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: >> From: Andy Yan <andy.yan@rock-chips.com> >> >> Add a Rockchip RK3588 compatible >> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > In the next iteration, please split this out into a separate patch and send > it to the iommu+dt maintainers. > > Supporting the iommus on rk3588 can be realized separately and the > patch needs to go through a separate tree anyway. Okay, I will split this patch out of this vop2 series, does this mean that I also need to split out the iommu dt node as a separate patch from current PATCH16 ? > > > Thanks > Heiko > > >
Hi Andy, Am Samstag, 9. Dezember 2023, 02:26:25 CET schrieb Andy Yan: > Hi Heiko: > > On 12/9/23 00:29, Heiko Stübner wrote: > > Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: > >> From: Andy Yan <andy.yan@rock-chips.com> > >> > >> Add a Rockchip RK3588 compatible > >> > >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > > In the next iteration, please split this out into a separate patch and send > > it to the iommu+dt maintainers. > > > > Supporting the iommus on rk3588 can be realized separately and the > > patch needs to go through a separate tree anyway. > > Okay, I will split this patch out of this vop2 series, does this mean that > I also need to split out the iommu dt node as a separate patch from current > PATCH16 ? no :-) . The vop-iommu can stay together with the vop core node. As adding the actual vop iommu is very much tied to the vop node. For the iommu-compatible it was different. The compatible just declares that the iommu acts similar to the one on rk3568, so is related to the iommu driver itself and should go through the iommu tree. So all is good here. Heiko
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml index ba9124f721f1..621dde0e45d8 100644 --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml @@ -19,9 +19,14 @@ description: |+ properties: compatible: - enum: - - rockchip,iommu - - rockchip,rk3568-iommu + oneOf: + - enum: + - rockchip,iommu + - rockchip,rk3568-iommu + - items: + - enum: + - rockchip,rk3588-iommu + - const: rockchip,rk3568-iommu reg: items: