| Message ID | 20231206135148.559564-1-579lpy@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: humidity: Add driver for ti HDC302x humidity sensors | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Dec 06, 2023 at 09:51:48PM +0800, Li peiyu wrote: > Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and > temperature sensors. > > Signed-off-by: Li peiyu <579lpy@gmail.com> If there is a resubmission, please prepend "dt-bindings: " to your commit $subject. Otherwise, I am only with this. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On 06/12/2023 14:51, Li peiyu wrote: > Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and > temperature sensors. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > > Signed-off-by: Li peiyu <579lpy@gmail.com> > --- Where is the changelog? It was here. This patch looks worse than it was before. > .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > > diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > new file mode 100644 > index 000000000000..f04b09fdca5e > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors > + > +maintainers: > + - Li peiyu <579lpy@gmail.com> > + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > + > +description: > + https://www.ti.com/lit/ds/symlink/hdc3020.pdf > + > + The HDC302x is an integrated capacitive based relative humidity (RH) > + and temperature sensor. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - ti,hdc3021 > + - ti,hdc3022 > + - const: ti,hdc3020 > + - items: Drop items > + - const: ti,hdc3020 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg How did you respond to Jonathan's feedback? Best regards, Krzysztof
On Thu, Dec 7, 2023 at 2:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > +--- > > +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors > > + > > +maintainers: > > + - Li peiyu <579lpy@gmail.com> > > + - Javier Carrasco <javier.carrasco.cruz@gmail.com> > > + > > +description: > > + https://www.ti.com/lit/ds/symlink/hdc3020.pdf > > + > > + The HDC302x is an integrated capacitive based relative humidity (RH) > > + and temperature sensor. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - ti,hdc3021 > > + - ti,hdc3022 > > + - const: ti,hdc3020 > > + - items: > > Drop items Does that mean just drop the "items" tag or drop the whole items with "- const: ti,hdc3020"? Thanks, Li peiyu
On 11/12/2023 11:37, peiyu li wrote: > On Thu, Dec 7, 2023 at 2:42 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >>> +--- >>> +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors >>> + >>> +maintainers: >>> + - Li peiyu <579lpy@gmail.com> >>> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> >>> + >>> +description: >>> + https://www.ti.com/lit/ds/symlink/hdc3020.pdf >>> + >>> + The HDC302x is an integrated capacitive based relative humidity (RH) >>> + and temperature sensor. >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - items: >>> + - enum: >>> + - ti,hdc3021 >>> + - ti,hdc3022 >>> + - const: ti,hdc3020 >>> + - items: >> >> Drop items > > Does that mean just drop the "items" tag or drop the whole items with > "- const: ti,hdc3020"? On this one line with "items", and re-indent appropriately. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml new file mode 100644 index 000000000000..f04b09fdca5e --- /dev/null +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors + +maintainers: + - Li peiyu <579lpy@gmail.com> + - Javier Carrasco <javier.carrasco.cruz@gmail.com> + +description: + https://www.ti.com/lit/ds/symlink/hdc3020.pdf + + The HDC302x is an integrated capacitive based relative humidity (RH) + and temperature sensor. + +properties: + compatible: + oneOf: + - items: + - enum: + - ti,hdc3021 + - ti,hdc3022 + - const: ti,hdc3020 + - items: + - const: ti,hdc3020 + + interrupts: + maxItems: 1 + + vdd-supply: true + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + humidity-sensor@47 { + compatible = "ti,hdc3021", "ti,hdc3020"; + reg = <0x47>; + vdd-supply = <&vcc_3v3>; + }; + };
Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and temperature sensors. Signed-off-by: Li peiyu <579lpy@gmail.com> --- .../bindings/iio/humidity/ti,hdc3020.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml