| Message ID | 20231206014236.1109832-2-jiajie.ho@starfivetech.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hwrng: starfive: Add support for JH8100 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 06/12/2023 02:42, Jia Jie Ho wrote: > Add compatible string for StarFive JH8100 trng. > > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> > --- > .../devicetree/bindings/rng/starfive,jh7110-trng.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml > index 2b76ce25acc4..d275bdc4d009 100644 > --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml > +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: starfive,jh7110-trng > + enum: > + - starfive,jh7110-trng > + - starfive,jh8100-trng Your driver change suggests these are compatible, so express this here and drop driver change. Best regards, Krzysztof
On 6/12/2023 6:17 pm, Krzysztof Kozlowski wrote: > On 06/12/2023 02:42, Jia Jie Ho wrote: >> Add compatible string for StarFive JH8100 trng. >> >> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> >> --- >> .../devicetree/bindings/rng/starfive,jh7110-trng.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml >> index 2b76ce25acc4..d275bdc4d009 100644 >> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml >> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml >> @@ -11,7 +11,9 @@ maintainers: >> >> properties: >> compatible: >> - const: starfive,jh7110-trng >> + enum: >> + - starfive,jh7110-trng >> + - starfive,jh8100-trng > > Your driver change suggests these are compatible, so express this here > and drop driver change. > I'll update the series accordingly. Thanks for reviewing this. Best regards, Jia Jie
diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml index 2b76ce25acc4..d275bdc4d009 100644 --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml @@ -11,7 +11,9 @@ maintainers: properties: compatible: - const: starfive,jh7110-trng + enum: + - starfive,jh7110-trng + - starfive,jh8100-trng reg: maxItems: 1
Add compatible string for StarFive JH8100 trng. Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> --- .../devicetree/bindings/rng/starfive,jh7110-trng.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)