| Message ID | 20231205074723.3546295-3-chou.cosmo@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hwmon: Add driver for Astera Labs PT516XX retimer | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Dec 05, 2023 at 03:47:22PM +0800, Cosmo Chou wrote: > Add dt-bindings for pt516xx temperature monitor. > > Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com> This can just go into trivial-devices.yaml, no? Thanks, Conor. > --- > .../bindings/hwmon/asteralabs,pt516xx.yaml | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > new file mode 100644 > index 000000000000..5700d4c91a0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/asteralabs,pt516xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PT5161L hwmon sensor > + > +maintainers: > + - Cosmo Chou <cosmo.chou@quantatw.com> > + > +properties: > + compatible: > + enum: > + - asteralabs,pt5161l > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor@24 { > + compatible = "asteralabs,pt5161l"; > + reg = <0x24>; > + }; > + }; > -- > 2.34.1 >
OK. I will change to trivial-devices.yaml. Thanks Cosmo On Tue, 5 Dec 2023 16:46:42 +0000, Conor Dooley <conor@kernel.org> wrote: > > On Tue, Dec 05, 2023 at 03:47:22PM +0800, Cosmo Chou wrote: > > Add dt-bindings for pt516xx temperature monitor. > > > > Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com> > > This can just go into trivial-devices.yaml, no? > > Thanks, > Conor. > > > --- > > .../bindings/hwmon/asteralabs,pt516xx.yaml | 36 +++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > > new file mode 100644 > > index 000000000000..5700d4c91a0d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml > > @@ -0,0 +1,36 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hwmon/asteralabs,pt516xx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PT5161L hwmon sensor > > + > > +maintainers: > > + - Cosmo Chou <cosmo.chou@quantatw.com> > > + > > +properties: > > + compatible: > > + enum: > > + - asteralabs,pt5161l > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + sensor@24 { > > + compatible = "asteralabs,pt5161l"; > > + reg = <0x24>; > > + }; > > + }; > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml new file mode 100644 index 000000000000..5700d4c91a0d --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/asteralabs,pt516xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: PT5161L hwmon sensor + +maintainers: + - Cosmo Chou <cosmo.chou@quantatw.com> + +properties: + compatible: + enum: + - asteralabs,pt5161l + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + sensor@24 { + compatible = "asteralabs,pt5161l"; + reg = <0x24>; + }; + };
Add dt-bindings for pt516xx temperature monitor. Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com> --- .../bindings/hwmon/asteralabs,pt516xx.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/asteralabs,pt516xx.yaml