| Message ID | 20231130173017.12723-1-johan+linaro@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: power: reset: qcom-pon: fix inconsistent example | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 29 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30/11/2023 18:30, Johan Hovold wrote: > The current PON example is a bit of a mess after converting the binding > document to yaml and in the process updating parts of the example to > match the pmk8350 binding while leaving parts from the older pm8998 > example in place. > > Clean up the example and make it consistent by adding some newline > separators; dropping labels; removing stray spaces; fixing the PON node > name; and fixing the unit address so that it matches the interrupt > specifiers (which re-encodes the PON base address, 0x800 => 0x8). > > Fixes: 76ba1900cb67 ("dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Sebastian, On Thu, Nov 30, 2023 at 06:30:17PM +0100, Johan Hovold wrote: > The current PON example is a bit of a mess after converting the binding > document to yaml and in the process updating parts of the example to > match the pmk8350 binding while leaving parts from the older pm8998 > example in place. > > Clean up the example and make it consistent by adding some newline > separators; dropping labels; removing stray spaces; fixing the PON node > name; and fixing the unit address so that it matches the interrupt > specifiers (which re-encodes the PON base address, 0x800 => 0x8). > > Fixes: 76ba1900cb67 ("dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> I noticed that this on is not yet in linux-next so sending a reminder. Johan
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml index 5e460128b0d1..fc8105a7b9b2 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml @@ -111,21 +111,24 @@ examples: #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/input/linux-event-codes.h> #include <dt-bindings/spmi/spmi.h> - spmi_bus: spmi@c440000 { + + spmi@c440000 { reg = <0x0c440000 0x1100>; #address-cells = <2>; #size-cells = <0>; - pmk8350: pmic@0 { + + pmic@0 { reg = <0x0 SPMI_USID>; #address-cells = <1>; #size-cells = <0>; - pmk8350_pon: pon_hlos@1300 { - reg = <0x1300>; + + pon@800 { compatible = "qcom,pm8998-pon"; + reg = <0x800>; pwrkey { compatible = "qcom,pm8941-pwrkey"; - interrupts = < 0x0 0x8 0 IRQ_TYPE_EDGE_BOTH >; + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; debounce = <15625>; bias-pull-up; linux,code = <KEY_POWER>;
The current PON example is a bit of a mess after converting the binding document to yaml and in the process updating parts of the example to match the pmk8350 binding while leaving parts from the older pm8998 example in place. Clean up the example and make it consistent by adding some newline separators; dropping labels; removing stray spaces; fixing the PON node name; and fixing the unit address so that it matches the interrupt specifiers (which re-encodes the PON base address, 0x800 => 0x8). Fixes: 76ba1900cb67 ("dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../devicetree/bindings/power/reset/qcom,pon.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)