diff mbox series

[v2,2/2] dt-bindings: firmware: Remove alt_ref from versal example

Message ID 20231127072204.25879-3-shubhrajyoti.datta@amd.com
State Changes Requested
Headers show
Series dt-bindings: Remove alt_ref for versal | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Shubhrajyoti Datta Nov. 27, 2023, 7:22 a.m. UTC
In the previous commit (dt-bindings: clock: versal: Make alt_ref
optional) the alt_ref is removed from the veral-clk. Update the example
accordingly.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---

Changes in v2:
new patch addition

 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Conor Dooley Nov. 27, 2023, 5:37 p.m. UTC | #1
On Mon, Nov 27, 2023 at 12:52:04PM +0530, Shubhrajyoti Datta wrote:
> In the previous commit (dt-bindings: clock: versal: Make alt_ref
> optional) the alt_ref is removed from the veral-clk. Update the example
> accordingly.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>

TBH, I'd rather you squashed this into patch one than introduced a
warning in one patch, only to remove it in another.

> ---
> 
> Changes in v2:
> new patch addition
> 
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 822864488dcb..8e584857ddd4 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -95,8 +95,8 @@ examples:
>        versal_clk: clock-controller {
>          #clock-cells = <1>;
>          compatible = "xlnx,versal-clk";
> -        clocks = <&ref>, <&alt_ref>, <&pl_alt_ref>;
> -        clock-names = "ref", "alt_ref", "pl_alt_ref";
> +        clocks = <&ref>, <&pl_alt_ref>;
> +        clock-names = "ref", "pl_alt_ref";
>        };
>      };
>  
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
index 822864488dcb..8e584857ddd4 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
@@ -95,8 +95,8 @@  examples:
       versal_clk: clock-controller {
         #clock-cells = <1>;
         compatible = "xlnx,versal-clk";
-        clocks = <&ref>, <&alt_ref>, <&pl_alt_ref>;
-        clock-names = "ref", "alt_ref", "pl_alt_ref";
+        clocks = <&ref>, <&pl_alt_ref>;
+        clock-names = "ref", "pl_alt_ref";
       };
     };