diff mbox series

[1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings

Message ID 20231125142914.57459-1-jagan@edgeble.ai
State Not Applicable
Headers show
Series [1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Jagan Teki Nov. 25, 2023, 2:29 p.m. UTC
Current binding has following compatible combination for SoM, IO board
- NCM6A: edgeble,neural-compute-module-6a,
	 edgeble,neural-compute-module-6a-io
- NCM6B: edgeble,neural-compute-module-6b,
	 edgeble,neural-compute-module-6b-io

This board topology now changes in final revisions, so a common
compatible IO board, NCM6A-IO, is made available for both variants
of SoM: NCM6A and NCM6B, produced by Edgeble AI.

With this change, 6b-io is not as available and 6a; 6b SoM's have the
same compatible IO board as 6a-io. This change is due to the common
optimised design of the IO board made available now in final revisions,
which was not the case in initial revisions.

Update the dt-bindings with this new change.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 .../devicetree/bindings/arm/rockchip.yaml          | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

Comments

Krzysztof Kozlowski Nov. 25, 2023, 6:10 p.m. UTC | #1
On 25/11/2023 15:29, Jagan Teki wrote:
> Current binding has following compatible combination for SoM, IO board
> - NCM6A: edgeble,neural-compute-module-6a,
> 	 edgeble,neural-compute-module-6a-io
> - NCM6B: edgeble,neural-compute-module-6b,
> 	 edgeble,neural-compute-module-6b-io
> 
> This board topology now changes in final revisions, so a common
> compatible IO board, NCM6A-IO, is made available for both variants
> of SoM: NCM6A and NCM6B, produced by Edgeble AI.
> 
> With this change, 6b-io is not as available and 6a; 6b SoM's have the
> same compatible IO board as 6a-io. This change is due to the common
> optimised design of the IO board made available now in final revisions,
> which was not the case in initial revisions.
> 
> Update the dt-bindings with this new change.
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 25, 2023, 6:10 p.m. UTC | #2
On 25/11/2023 15:29, Jagan Teki wrote:
> Edgeble AI 6TOPS board topology is now changed in final revisions
> as a compatible IO board, NCM6A-IO, is made available for both
> variants of SoM: NCM6A and NCM6B.
> 
> With this change, 6b-io is not as available and 6a; 6b SoM's have
> the same compatible IO board as 6a-io. This change is due to the
> common optimised design of the IO board made available now in
> final revisions, which was not the case in initial revisions.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Heiko Stuebner Nov. 27, 2023, 11:26 p.m. UTC | #3
On Sat, 25 Nov 2023 19:59:13 +0530, Jagan Teki wrote:
> Current binding has following compatible combination for SoM, IO board
> - NCM6A: edgeble,neural-compute-module-6a,
> 	 edgeble,neural-compute-module-6a-io
> - NCM6B: edgeble,neural-compute-module-6b,
> 	 edgeble,neural-compute-module-6b-io
> 
> This board topology now changes in final revisions, so a common
> compatible IO board, NCM6A-IO, is made available for both variants
> of SoM: NCM6A and NCM6B, produced by Edgeble AI.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings
      commit: 02dbe73da5c4f6a8dc7c381b21c181006a06fb90
[2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b
      commit: ec31f0f98433f0edf456e2074301b76bdace5f3d

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 9f6155e4deed..75f23d1d42ae 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -101,16 +101,12 @@  properties:
           - const: edgeble,neural-compute-module-2      # Edgeble Neural Compute Module 2 SoM
           - const: rockchip,rv1126
 
-      - description: Edgeble Neural Compute Module 6(Neu6) Model A SoM based boards
+      - description: Edgeble Neural Compute Module 6(Neu6) SoM based boards
         items:
-          - const: edgeble,neural-compute-module-6a-io  # Edgeble Neural Compute Module 6A IO Board
-          - const: edgeble,neural-compute-module-6a     # Edgeble Neural Compute Module 6A SoM
-          - const: rockchip,rk3588
-
-      - description: Edgeble Neural Compute Module 6(Neu6) Model B SoM based boards
-        items:
-          - const: edgeble,neural-compute-module-6b-io  # Edgeble Neural Compute Module 6B IO Board
-          - const: edgeble,neural-compute-module-6b     # Edgeble Neural Compute Module 6B SoM
+          - const: edgeble,neural-compute-module-6a-io  # Edgeble NCM6A-IO Board
+          - enum:
+              - edgeble,neural-compute-module-6a        # Edgeble Neural Compute Module 6A SoM
+              - edgeble,neural-compute-module-6b        # Edgeble Neural Compute Module 6B SoM
           - const: rockchip,rk3588
 
       - description: Elgin RV1108 R1