| Message ID | 20231125100139.193584-2-anshulusr@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4,1/3] dt-bindings: vendor-prefixes: add aosong | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/11/2023 11:01, Anshul Dalal wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On Sat, 25 Nov 2023 15:31:37 +0530 Anshul Dalal <anshulusr@gmail.com> wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > --- > > Changes for v4: > - Changed node name from 'light-sensor' to 'voc-sensor' > > v3: https://lore.kernel.org/lkml/20231121095800.2180870-2-anshulusr@gmail.com/ > > Changes for v3: > - Fixed commit message > - Removed "asair,ags02ma" compatible > > v2: https://lore.kernel.org/lkml/20231115125810.1394854-2-anshulusr@gmail.com/ > > Changes for v2: > - Removed device from trivial-devices > - Added standalone binding with vdd-supply property > > v1: https://lore.kernel.org/lkml/20231107173100.62715-2-anshulusr@gmail.com/ > --- > .../bindings/iio/chemical/aosong,ags02ma.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > new file mode 100644 > index 000000000000..c176a6e102ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aosong AGS02MA VOC Sensor > + > +description: | > + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > + address of 0x1a. > + > + Datasheet: > + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > + > +maintainers: > + - Anshul Dalal <anshulusr@gmail.com> > + > +properties: > + compatible: > + enum: > + - aosong,ags02ma > + > + reg: > + maxItems: 1 > + > + vdd-supply: true Similar to other review (I put more background there) Convention these days at least is to always require powersupplies that the device cannot work with out (even if you can use a fixed supply and rely on the regulator framework papering over that). We want to distinguish generally optional supplies from ones we might not specify in a given DT. Jonathan > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + voc-sensor@1a { > + compatible = "aosong,ags02ma"; > + reg = <0x1a>; > + vdd-supply = <&vdd_regulator>; > + }; > + };
diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml new file mode 100644 index 000000000000..c176a6e102ac --- /dev/null +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aosong AGS02MA VOC Sensor + +description: | + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default + address of 0x1a. + + Datasheet: + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf + +maintainers: + - Anshul Dalal <anshulusr@gmail.com> + +properties: + compatible: + enum: + - aosong,ags02ma + + reg: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + voc-sensor@1a { + compatible = "aosong,ags02ma"; + reg = <0x1a>; + vdd-supply = <&vdd_regulator>; + }; + };
Add bindings for Aosong AGS02MA TVOC sensor. The sensor communicates over i2c with the default address 0x1a. TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. Datasheet: https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf Product-Page: http://www.aosong.com/m/en/products-33.html Signed-off-by: Anshul Dalal <anshulusr@gmail.com> --- Changes for v4: - Changed node name from 'light-sensor' to 'voc-sensor' v3: https://lore.kernel.org/lkml/20231121095800.2180870-2-anshulusr@gmail.com/ Changes for v3: - Fixed commit message - Removed "asair,ags02ma" compatible v2: https://lore.kernel.org/lkml/20231115125810.1394854-2-anshulusr@gmail.com/ Changes for v2: - Removed device from trivial-devices - Added standalone binding with vdd-supply property v1: https://lore.kernel.org/lkml/20231107173100.62715-2-anshulusr@gmail.com/ --- .../bindings/iio/chemical/aosong,ags02ma.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml