| Message ID | 20231125-topic-rb1_feat-v1-3-11d71b12b058@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | RB1/QCM2290 features | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 25/11/2023 15:17, Konrad Dybcio wrote: > In addition to MDP0, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml > index 3d82c00a9f85..51f3e9c34dfb 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml > @@ -36,10 +36,10 @@ properties: > maxItems: 2 > > interconnects: > - maxItems: 1 > + maxItems: 2 > > interconnect-names: > - maxItems: 1 > + maxItems: 2 You should describe the items in interconnects and interconnect-names in such case. The same for all other variants having two items here. Then this and other such patches should be squashed with previous. Best regards, Krzysztof
On Sat, 25 Nov 2023 15:17:31 +0100, Konrad Dybcio wrote: > In addition to MDP0, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000: interconnects: [[4294967295, 1, 4294967295, 6]] is too short from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000: interconnect-names: ['mdp0-mem'] is too short from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231125-topic-rb1_feat-v1-3-11d71b12b058@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml index 3d82c00a9f85..51f3e9c34dfb 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml @@ -36,10 +36,10 @@ properties: maxItems: 2 interconnects: - maxItems: 1 + maxItems: 2 interconnect-names: - maxItems: 1 + maxItems: 2 patternProperties: "^display-controller@[0-9a-f]+$":
In addition to MDP0, the cpu-cfg interconnect is also necessary. Allow it. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)