| Message ID | 20231117104254.28862-2-quic_sibis@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | pmdomain: qcom: Update part number to X1E80100 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 14 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/11/2023 11:42, Sibi Sankar wrote: > Replace SC8380xp with the updated part number (X1E80100). > You need to explain why. We don't update compatibles based on marketing wishes. Best regards, Krzysztof
Hey Krzysztof, Thanks for taking time to review the series. On 11/17/23 16:35, Krzysztof Kozlowski wrote: > On 17/11/2023 11:42, Sibi Sankar wrote: >> Replace SC8380xp with the updated part number (X1E80100). >> > > You need to explain why. We don't update compatibles based on marketing > wishes. What we imply is that X1E80100 is the part number you would get when you read out from a Snapdragon X Elite device in the wild, when it is available and we didn't have this information when we posted out v1. -Sibi > > Best regards, > Krzysztof >
On 17/11/2023 12:46, Sibi Sankar wrote: > Hey Krzysztof, > > Thanks for taking time to review the series. > > On 11/17/23 16:35, Krzysztof Kozlowski wrote: >> On 17/11/2023 11:42, Sibi Sankar wrote: >>> Replace SC8380xp with the updated part number (X1E80100). >>> >> >> You need to explain why. We don't update compatibles based on marketing >> wishes. > > What we imply is that X1E80100 is the part number you would get when you > read out from a Snapdragon X Elite device in the wild, when it is > available and we didn't have this information when we posted out v1. The commit msg must explain why. Best regards, Krzysztof
On 17.11.2023 13:39, Krzysztof Kozlowski wrote: > On 17/11/2023 12:46, Sibi Sankar wrote: >> Hey Krzysztof, >> >> Thanks for taking time to review the series. >> >> On 11/17/23 16:35, Krzysztof Kozlowski wrote: >>> On 17/11/2023 11:42, Sibi Sankar wrote: >>>> Replace SC8380xp with the updated part number (X1E80100). >>>> >>> >>> You need to explain why. We don't update compatibles based on marketing >>> wishes. >> >> What we imply is that X1E80100 is the part number you would get when you >> read out from a Snapdragon X Elite device in the wild, when it is >> available and we didn't have this information when we posted out v1. > > The commit msg must explain why. (what Krzysztof meant is that your explanation is ok but it needs to be part of the commit message and not just a reply here) Moreover, it would also be good to say something like "this binding has no users and has been erroneusly introduced very recently, so it was decided that changing it is okay", as this is a rather special case. Konrad
On 11/18/23 05:10, Konrad Dybcio wrote: > On 17.11.2023 13:39, Krzysztof Kozlowski wrote: >> On 17/11/2023 12:46, Sibi Sankar wrote: >>> Hey Krzysztof, >>> >>> Thanks for taking time to review the series. >>> >>> On 11/17/23 16:35, Krzysztof Kozlowski wrote: >>>> On 17/11/2023 11:42, Sibi Sankar wrote: >>>>> Replace SC8380xp with the updated part number (X1E80100). >>>>> >>>> >>>> You need to explain why. We don't update compatibles based on marketing >>>> wishes. >>> >>> What we imply is that X1E80100 is the part number you would get when you >>> read out from a Snapdragon X Elite device in the wild, when it is >>> available and we didn't have this information when we posted out v1. >> >> The commit msg must explain why. > (what Krzysztof meant is that your explanation is ok but it needs to be > part of the commit message and not just a reply here) > > Moreover, it would also be good to say something like "this binding has > no users and has been erroneusly introduced very recently, so it was > decided that changing it is okay", as this is a rather special case. Thanks, was going to do the same. -Sibi > > Konrad
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml index da9c5846f4e1..2ff246cf8b81 100644 --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml @@ -39,7 +39,6 @@ properties: - qcom,sc7280-rpmhpd - qcom,sc8180x-rpmhpd - qcom,sc8280xp-rpmhpd - - qcom,sc8380xp-rpmhpd - qcom,sdm660-rpmpd - qcom,sdm670-rpmhpd - qcom,sdm845-rpmhpd @@ -57,6 +56,7 @@ properties: - qcom,sm8450-rpmhpd - qcom,sm8550-rpmhpd - qcom,sm8650-rpmhpd + - qcom,x1e80100-rpmhpd - items: - enum: - qcom,msm8937-rpmpd
Replace SC8380xp with the updated part number (X1E80100). Fixes: c638b9516abd ("dt-bindings: power: rpmpd: Add SC8380XP support") Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)