| Message ID | 20231117101817.4401-2-quic_tengfan@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: qcom: add sm8550-aim300 board support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/11/2023 11:18, Tengfei Fan wrote:
> Add board compatible for SM8550 AIM300.
Subject, commit msg and compatible tell basically the same... and none
of them tell me what is AIM300.
Best regards,
Krzysztof
On 17/11/2023 11:22, Krzysztof Kozlowski wrote: > On 17/11/2023 11:18, Tengfei Fan wrote: >> Add board compatible for SM8550 AIM300. > > Subject, commit msg and compatible tell basically the same... and none > of them tell me what is AIM300. Due to lack of explanation it is difficult to judge what's this. However based on pieces of information I got, it looks like it is not a board, so it is not suitable to be DTS, but DTSI. You still need a board... Best regards, Krzysztof
在 11/20/2023 4:53 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:22, Krzysztof Kozlowski wrote: >> On 17/11/2023 11:18, Tengfei Fan wrote: >>> Add board compatible for SM8550 AIM300. >> >> Subject, commit msg and compatible tell basically the same... and none >> of them tell me what is AIM300. > > Due to lack of explanation it is difficult to judge what's this. However > based on pieces of information I got, it looks like it is not a board, > so it is not suitable to be DTS, but DTSI. You still need a board... > > Best regards, > Krzysztof > Hi Krzysztof, AIM (Artificial Intelligence Module). This hardware platform can be used to develop AI related software based on Qualcomm chipset. I also will update this message to patch commit message. I also will sync with internal team about if we should create DTSI file as your suggestion. The email update was delayed because I asked for a day off yesterday.
On 21/11/2023 01:30, Tengfei Fan wrote: > > > 在 11/20/2023 4:53 PM, Krzysztof Kozlowski 写道: >> On 17/11/2023 11:22, Krzysztof Kozlowski wrote: >>> On 17/11/2023 11:18, Tengfei Fan wrote: >>>> Add board compatible for SM8550 AIM300. >>> >>> Subject, commit msg and compatible tell basically the same... and none >>> of them tell me what is AIM300. >> >> Due to lack of explanation it is difficult to judge what's this. However >> based on pieces of information I got, it looks like it is not a board, >> so it is not suitable to be DTS, but DTSI. You still need a board... >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > AIM (Artificial Intelligence Module). This hardware platform can be used > to develop AI related software based on Qualcomm chipset. I also will > update this message to patch commit message. Does "Module" means it is physical module? > > I also will sync with internal team about if we should create DTSI file > as your suggestion. Do they know how DTS should be organized upstream (not downstream)? Best regards, Krzysztof
On 11/21/23 08:18, Krzysztof Kozlowski wrote: > On 21/11/2023 01:30, Tengfei Fan wrote: >> >> >> 在 11/20/2023 4:53 PM, Krzysztof Kozlowski 写道: >>> On 17/11/2023 11:22, Krzysztof Kozlowski wrote: >>>> On 17/11/2023 11:18, Tengfei Fan wrote: >>>>> Add board compatible for SM8550 AIM300. >>>> >>>> Subject, commit msg and compatible tell basically the same... and none >>>> of them tell me what is AIM300. >>> >>> Due to lack of explanation it is difficult to judge what's this. However >>> based on pieces of information I got, it looks like it is not a board, >>> so it is not suitable to be DTS, but DTSI. You still need a board... >>> >>> Best regards, >>> Krzysztof >>> >> >> Hi Krzysztof, >> AIM (Artificial Intelligence Module). This hardware platform can be used >> to develop AI related software based on Qualcomm chipset. I also will >> update this message to patch commit message. > > Does "Module" means it is physical module? Moreover, does it have anything specific that makes it different from a MTP/QRD/regular 8550 SoM? In general, you can develop AI software on any computer, there are no runtime checks for "AI" presence in the naming ;) Or is it perhaps like QRB5165N [1], a base soc with what seems to be a fat AI accelerator connected to it? Konrad [1] https://www.thundercomm.com/product/qualcomm-robotics-rb6-development-kit/#specifications
在 11/23/2023 3:35 AM, Konrad Dybcio 写道: > > > On 11/21/23 08:18, Krzysztof Kozlowski wrote: >> On 21/11/2023 01:30, Tengfei Fan wrote: >>> >>> >>> 在 11/20/2023 4:53 PM, Krzysztof Kozlowski 写道: >>>> On 17/11/2023 11:22, Krzysztof Kozlowski wrote: >>>>> On 17/11/2023 11:18, Tengfei Fan wrote: >>>>>> Add board compatible for SM8550 AIM300. >>>>> >>>>> Subject, commit msg and compatible tell basically the same... and none >>>>> of them tell me what is AIM300. >>>> >>>> Due to lack of explanation it is difficult to judge what's this. >>>> However >>>> based on pieces of information I got, it looks like it is not a board, >>>> so it is not suitable to be DTS, but DTSI. You still need a board... >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Hi Krzysztof, >>> AIM (Artificial Intelligence Module). This hardware platform can be used >>> to develop AI related software based on Qualcomm chipset. I also will >>> update this message to patch commit message. >> >> Does "Module" means it is physical module? Yes, AIM300 is a physical module. > Moreover, does it have anything specific that makes it different from > a MTP/QRD/regular 8550 SoM? > In general, you can develop AI software on any computer, there are no > runtime checks for "AI" presence in the naming ;) > > Or is it perhaps like QRB5165N [1], a base soc with what seems to > be a fat AI accelerator connected to it? AIM300 is something like C5165N SOM. AIM300 Series is a highly optimized family of modules designed to support AIoT applications, intergrated with qualcomm qcs8550 SOC inside. The Module is mounted onto Qualcomm AIoT carrier board to support verification, evaluation and development. In next patch series, AIM300 AIoT carrier board will be a DTS, AIM300 will be a DTSI, qcs8550 will be a DTSI. > > Konrad > > [1] > https://www.thundercomm.com/product/qualcomm-robotics-rb6-development-kit/#specifications
On 24/11/2023 03:31, Tengfei Fan wrote: >>>> AIM (Artificial Intelligence Module). This hardware platform can be used >>>> to develop AI related software based on Qualcomm chipset. I also will >>>> update this message to patch commit message. >>> >>> Does "Module" means it is physical module? > Yes, AIM300 is a physical module. > >> Moreover, does it have anything specific that makes it different from >> a MTP/QRD/regular 8550 SoM? >> In general, you can develop AI software on any computer, there are no >> runtime checks for "AI" presence in the naming ;) >> >> Or is it perhaps like QRB5165N [1], a base soc with what seems to >> be a fat AI accelerator connected to it? > > AIM300 is something like C5165N SOM. > AIM300 Series is a highly optimized family of modules designed to > support AIoT applications, intergrated with qualcomm qcs8550 SOC inside. > The Module is mounted onto Qualcomm AIoT carrier board to support > verification, evaluation and development. Then you send patches for wrong board. AIM is not a board. > > In next patch series, AIM300 AIoT carrier board will be a DTS, AIM300 > will be a DTSI, qcs8550 will be a DTSI. Best regards, Krzysztof
在 11/24/2023 3:47 PM, Krzysztof Kozlowski 写道: > On 24/11/2023 03:31, Tengfei Fan wrote: > >>>>> AIM (Artificial Intelligence Module). This hardware platform can be used >>>>> to develop AI related software based on Qualcomm chipset. I also will >>>>> update this message to patch commit message. >>>> >>>> Does "Module" means it is physical module? >> Yes, AIM300 is a physical module. >> >>> Moreover, does it have anything specific that makes it different from >>> a MTP/QRD/regular 8550 SoM? >>> In general, you can develop AI software on any computer, there are no >>> runtime checks for "AI" presence in the naming ;) >>> >>> Or is it perhaps like QRB5165N [1], a base soc with what seems to >>> be a fat AI accelerator connected to it? >> >> AIM300 is something like C5165N SOM. >> AIM300 Series is a highly optimized family of modules designed to >> support AIoT applications, intergrated with qualcomm qcs8550 SOC inside. >> The Module is mounted onto Qualcomm AIoT carrier board to support >> verification, evaluation and development. > > Then you send patches for wrong board. AIM is not a board. Yes, I used AIM as board by mistake, AIM300 AIOT is board. >> >> In next patch series, AIM300 AIoT carrier board will be a DTS, AIM300 >> will be a DTSI, qcs8550 will be a DTSI. > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 88b84035e7b1..26aee6058bfd 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -1040,6 +1040,7 @@ properties: - items: - enum: + - qcom,sm8550-aim300 - qcom,sm8550-mtp - qcom,sm8550-qrd - const: qcom,sm8550
Add board compatible for SM8550 AIM300. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)