| Message ID | 20231116023027.24855-2-Delphine_CC_Chiu@Wiwynn.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | LTC4286 and LTC4287 driver support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 16/11/2023 03:30, Delphine CC Chiu wrote: > Add a device tree bindings for ltc4286 device. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > ------------------------------------------------------------- > Changelog: > v5 - Add hyphen under "Changelog" in commit message Apply your patch from the list and check the result... You can easily see it's broken. We asked about ---. Please read the message carefully. Best regards, Krzysztof
On Thu, Nov 16, 2023 at 01:13:58PM +0100, Krzysztof Kozlowski wrote: > On 16/11/2023 03:30, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 device. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > > > ------------------------------------------------------------- > > Changelog: > > v5 - Add hyphen under "Changelog" in commit message > > Apply your patch from the list and check the result... You can easily > see it's broken. We asked about ---. Please read the message carefully. My reviewed-by was also omitted again, but I suppose that is a good thing since I conditionally gave that based on the changelog being fixed!
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, November 16, 2023 8:14 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>; > patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck > <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org> > Cc: Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org; > linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org > Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > Security Reminder: Please be aware that this email is sent by an external > sender. > > On 16/11/2023 03:30, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 device. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > > > ------------------------------------------------------------- > > Changelog: > > v5 - Add hyphen under "Changelog" in commit message > > Apply your patch from the list and check the result... You can easily see it's > broken. We asked about ---. Please read the message carefully. We will add --- Thanks. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml new file mode 100644 index 000000000000..d26f34fb7ea7 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LTC4286 power monitors + +maintainers: + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> + +properties: + compatible: + enum: + - lltc,ltc4286 + - lltc,ltc4287 + + reg: + maxItems: 1 + + adi,vrange-low-enable: + description: + This property is a bool parameter to represent the + voltage range is 25.6 volts or 102.4 volts for this chip. + The default is 102.4 volts. + type: boolean + + shunt-resistor-micro-ohms: + description: + Resistor value micro-ohms. + +required: + - compatible + - reg + - shunt-resistor-micro-ohms + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + power-monitor@40 { + compatible = "lltc,ltc4286"; + reg = <0x40>; + adi,vrange-low-enable; + shunt-resistor-micro-ohms = <300>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 5c9f868e13b6..2a73a7c0f160 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12628,6 +12628,16 @@ S: Maintained F: Documentation/hwmon/ltc4261.rst F: drivers/hwmon/ltc4261.c +LTC4286 HARDWARE MONITOR DRIVER +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> +L: linux-i2c@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml +F: Documentation/devicetree/bindings/hwmon/ltc4286.rst +F: drivers/hwmon/pmbus/Kconfig +F: drivers/hwmon/pmbus/Makefile +F: drivers/hwmon/pmbus/ltc4286.c + LTC4306 I2C MULTIPLEXER DRIVER M: Michael Hennerich <michael.hennerich@analog.com> L: linux-i2c@vger.kernel.org
Add a device tree bindings for ltc4286 device. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> ------------------------------------------------------------- Changelog: v5 - Add hyphen under "Changelog" in commit message v4 - Revise some inappropriate writing in yaml file v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 - Add type for adi,vrange-select-25p6 - Revise rsense-micro-ohms to shunt-resistor-micro-ohms --- .../bindings/hwmon/lltc,ltc4286.yaml | 51 +++++++++++++++++++ MAINTAINERS | 10 ++++ 2 files changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml