| Message ID | 20231107-refclk_always_on-v2-1-de23962fc4b3@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: qcom-qmp-pcie: Add support to keep refclk always on | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, 7 Nov 2023 at 14:26, Krishna chaitanya chundru <quic_krichai@quicinc.com> wrote: > > Document qcom,refclk-always-on property which is needed in some platforms > to supply refclk even in PCIe low power states. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > index 2c3d6553a7ba..263291447a5b 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > @@ -93,6 +93,13 @@ properties: > "#phy-cells": > const: 0 > > + qcom,refclk-always-on: > + type: boolean > + description: If there is some issues in platform with clkreq signal nit: there are some However this still doesn't describe what kind of issues with clkreq you observe. I mean, clkreq is just a GPIO pin. > + propagation to the host and due to that host will not send refclk, which > + results in linkdown in L1.2 or L1.1 exit initiated by EP. This property > + if set keeps refclk always on even in Low power states (optional). > + > required: > - compatible > - reg > > -- > 2.42.0 > >
On Tue, Nov 07, 2023 at 03:01:47PM +0200, Dmitry Baryshkov wrote: > On Tue, 7 Nov 2023 at 14:26, Krishna chaitanya chundru > <quic_krichai@quicinc.com> wrote: > > > > Document qcom,refclk-always-on property which is needed in some platforms > > to supply refclk even in PCIe low power states. > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > --- > > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > index 2c3d6553a7ba..263291447a5b 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > > @@ -93,6 +93,13 @@ properties: > > "#phy-cells": > > const: 0 > > > > + qcom,refclk-always-on: > > + type: boolean > > + description: If there is some issues in platform with clkreq signal > > nit: there are some > > However this still doesn't describe what kind of issues with clkreq > you observe. I mean, clkreq is just a GPIO pin. > > > + propagation to the host and due to that host will not send refclk, which > > + results in linkdown in L1.2 or L1.1 exit initiated by EP. This property > > + if set keeps refclk always on even in Low power states (optional). Dimitry's issues with the property aside, putting "(optional)" in the description is meaningless - qcom,refclk-always-on isn't listed in the required properties section, so therefore has to be optional. Cheers, Conor. > > + > > required: > > - compatible > > - reg > > > > -- > > 2.42.0 > > > > > > > -- > With best wishes > Dmitry
On 11/8/2023 9:22 PM, Conor Dooley wrote: > On Tue, Nov 07, 2023 at 03:01:47PM +0200, Dmitry Baryshkov wrote: >> On Tue, 7 Nov 2023 at 14:26, Krishna chaitanya chundru >> <quic_krichai@quicinc.com> wrote: >>> Document qcom,refclk-always-on property which is needed in some platforms >>> to supply refclk even in PCIe low power states. >>> >>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >>> --- >>> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >>> index 2c3d6553a7ba..263291447a5b 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >>> @@ -93,6 +93,13 @@ properties: >>> "#phy-cells": >>> const: 0 >>> >>> + qcom,refclk-always-on: >>> + type: boolean >>> + description: If there is some issues in platform with clkreq signal >> nit: there are some >> >> However this still doesn't describe what kind of issues with clkreq >> you observe. I mean, clkreq is just a GPIO pin. >> >>> + propagation to the host and due to that host will not send refclk, which >>> + results in linkdown in L1.2 or L1.1 exit initiated by EP. This property >>> + if set keeps refclk always on even in Low power states (optional). > Dimitry's issues with the property aside, putting "(optional)" in the > description is meaningless - qcom,refclk-always-on isn't listed in the > required properties section, so therefore has to be optional. > > Cheers, > Conor. I removed the optional flag and updated the description. - Krishna chaitanya. >>> + >>> required: >>> - compatible >>> - reg >>> >>> -- >>> 2.42.0 >>> >>> >> >> -- >> With best wishes >> Dmitry
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml index 2c3d6553a7ba..263291447a5b 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -93,6 +93,13 @@ properties: "#phy-cells": const: 0 + qcom,refclk-always-on: + type: boolean + description: If there is some issues in platform with clkreq signal + propagation to the host and due to that host will not send refclk, which + results in linkdown in L1.2 or L1.1 exit initiated by EP. This property + if set keeps refclk always on even in Low power states (optional). + required: - compatible - reg
Document qcom,refclk-always-on property which is needed in some platforms to supply refclk even in PCIe low power states. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++ 1 file changed, 7 insertions(+)